Update sample to call preload at a more appropriate time (#122)

update sample to call preload at a more appropriate time
Shopify · Oct 8, 2024 · 10b21f6 · 10b21f6
1 parent a921f2f
commit 10b21f6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -10,7 +10,7 @@
 
 ### Requirements
 
-- JDK 11+
+- JDK 17+
 - Android SDK 23+
 - The SDK is not compatible with checkout.liquid. The Shopify Store must be migrated for extensibility
 

diff --git a/...app/src/main/java/com/shopify/checkout_sdk_mobile_buy_integration_sample/cart/CartView.kt b/...app/src/main/java/com/shopify/checkout_sdk_mobile_buy_integration_sample/cart/CartView.kt
@@ -53,6 +53,7 @@ import androidx.compose.ui.unit.sp
 import com.shopify.checkout_sdk_mobile_buy_integration_sample.AppBarState
 import com.shopify.checkout_sdk_mobile_buy_integration_sample.common.toDisplayText
 import com.shopify.checkoutsheetkit.DefaultCheckoutEventProcessor
+import com.shopify.checkoutsheetkit.ShopifyCheckoutSheetKit
 
 @Composable
 fun <T: DefaultCheckoutEventProcessor> CartView(
@@ -61,6 +62,7 @@ fun <T: DefaultCheckoutEventProcessor> CartView(
     checkoutEventProcessor: T,
 ) {
     val state = cartViewModel.cartState.collectAsState().value
+    val activity = LocalContext.current as ComponentActivity
 
     LaunchedEffect(state) {
         setAppBarState(
@@ -78,6 +80,10 @@ fun <T: DefaultCheckoutEventProcessor> CartView(
                 }
             )
         )
+
+        if (state is CartState.Populated) {
+            ShopifyCheckoutSheetKit.preload(state.checkoutUrl, activity)
+        }
     }
 
     Column(

diff --git a/...c/main/java/com/shopify/checkout_sdk_mobile_buy_integration_sample/product/ProductView.kt b/...c/main/java/com/shopify/checkout_sdk_mobile_buy_integration_sample/product/ProductView.kt
@@ -54,7 +54,6 @@ fun ProductView(
 ) {
 
     val productUIState = productViewModel.uiState.collectAsState().value
-    val activity = LocalContext.current as ComponentActivity
 
     LaunchedEffect(productUIState) {
         setAppBarState(
@@ -124,9 +123,6 @@ fun ProductView(
                             productViewModel.setIsAddingToCart(true)
                             cartViewModel.addToCart(selectedVariant.id) {
                                 productViewModel.setIsAddingToCart(false)
-                                if (it?.checkoutUrl != null) {
-                                    ShopifyCheckoutSheetKit.preload(it.checkoutUrl, activity)
-                                }
                             }
                         }
                     }