Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs and annotations for colors #16

Merged
merged 2 commits into from
Nov 24, 2023
Merged

add docs and annotations for colors #16

merged 2 commits into from
Nov 24, 2023

Conversation

Bruno125
Copy link
Contributor

What are you trying to accomplish?

  • Add docs to the new public Color classes
  • Add annotations (@ColorInt and @ColorRes) for a more robust value enforcement (int is too generic)

Before you deploy

@Bruno125 Bruno125 requested a review from kiftio November 24, 2023 17:40
@Bruno125 Bruno125 requested a review from a team as a code owner November 24, 2023 17:40
Copy link
Contributor

@kiftio kiftio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@kiftio kiftio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more semi-related thing. Do you think we should also make these public instaed of internal?

public data class Automatic(
        internal var lightColors: Colors = defaultLightColors,
        internal var darkColors: Colors = defaultDarkColors

@Bruno125 Bruno125 merged commit 81732f1 into main Nov 24, 2023
4 checks passed
@Bruno125 Bruno125 deleted the color-annotations branch November 24, 2023 18:22
@markmur markmur mentioned this pull request Nov 27, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants