override onRenderProcessGone #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiftio
commented
Nov 22, 2023
| @@ -107,7 +107,9 @@ internal class CheckoutDialog( | |||
|
|
|||
| setOnCancelListener { | |||
| checkoutEventProcessor.onCheckoutCanceled() | |||
| (checkoutWebView.parent as ViewGroup).removeView(checkoutWebView) | |||
| checkoutWebView.parent?.let { | |||
There was a problem hiding this comment.
parent may now be removed in onRenderProcessGone, so we should do a null check here
cianbuckley
reviewed
Nov 22, 2023
cianbuckley
approved these changes
Nov 22, 2023
markmur
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Implement
onRenderProcessGone, to handle cases where the renderer process for a WebView object goes away because the system has killed it to reclaim memory.Left unhandled, the app would crash in this case. But by using this API, we can let it continue executing.
To handle it, we need to remove the WebView from the view hierarchy, and destroy the instance. We could also try to create a new instance of the WebView, but that is not covered in this PR.
The behaviour after this PR is that the app wouldn't crash, but users would see a blank WebView that can be closed.
Docs
Before you deploy
the contributing documentation
the code of conduct documentation