Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use app context in app dev #4680

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Oct 18, 2024

WHY are these changes introduced?

Use the generic app-context for all commands

WHAT is this pull request doing?

  • Use linkedAppContext and storeContext in app dev
  • Remove ensureDevContext, getAppContext and other utility functions
  • Move some logic from context to dev service.

How to test your changes?

Test dev!

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@isaacroldan isaacroldan changed the base branch from main to use-app-context-in-app-logs October 18, 2024 07:41
Copy link
Contributor

github-actions bot commented Oct 18, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.1% (-0.42% 🔻)
8296/11507
🟡 Branches
68.44% (-0.59% 🔻)
4044/5909
🟡 Functions
71.8% (-0.15% 🔻)
2185/3043
🟡 Lines
72.4% (-0.39% 🔻)
7847/10839
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / context.ts
45.71% (-30.45% 🔻)
34.07% (-38.66% 🔻)
58.33% (-19.09% 🔻)
45.08% (-30.69% 🔻)
🔴
... / dev.ts
19.53% (-0.47% 🔻)
14.93% 24.39%
20.34% (-0.53% 🔻)
🟢
... / ConcurrentOutput.tsx
98.39% (-1.61% 🔻)
90.91% (-4.55% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

1901 tests passing in 869 suites.

Report generated by 🧪jest coverage report action from dd388c0

Base automatically changed from use-app-context-in-app-logs to main October 18, 2024 07:46
@Shopify Shopify deleted a comment from github-actions bot Oct 18, 2024
@isaacroldan isaacroldan marked this pull request as ready for review October 18, 2024 10:15
@isaacroldan isaacroldan requested a review from a team as a code owner October 18, 2024 10:15
Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@isaacroldan
Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/cli@0.0.0-snapshot-20241018104722

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant