Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog: bump CLI, add mini-oxygen #2582

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

scottdixon
Copy link
Contributor

Hey @frandiox! Does this look good to you? 🙏

Copy link
Contributor

shopify bot commented Oct 2, 2024

Oxygen deployed a preview of your sd-changelog-updates branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment October 2, 2024 5:21 AM
sitemap ✅ Successful (Logs) Preview deployment Inspect deployment October 2, 2024 5:21 AM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment October 2, 2024 5:21 AM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment October 2, 2024 5:21 AM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment October 2, 2024 5:21 AM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment October 2, 2024 5:22 AM

Learn more about Hydrogen's GitHub integration.

Copy link
Contributor

@frandiox frandiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 👍
But you may want to update the local dependencies for @shopify/cli, @shopify/cli-kit and @shopify/plugin-cloudflare to be as close as possible to the latest release of @shopify/cli to avoid possible issues 🤔
For example, new projects won't get 3.68.0 by default right now: https://github.com/Shopify/hydrogen/blob/main/templates/skeleton/package.json#L31
Instead, they will get 3.66 and a terminal warning to upgrade to 3.68. That's why it's good to update our CLI related deps before every release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants