Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests to run locally and in CI and misc fixes #949

Merged
merged 12 commits into from
Feb 9, 2024
Merged

fix tests to run locally and in CI and misc fixes #949

merged 12 commits into from
Feb 9, 2024

Conversation

sumedhpd
Copy link
Contributor

@sumedhpd sumedhpd commented Feb 8, 2024

  1. Events aren't available when running tests locally in kind via dev test integration_test
  2. k8s now shows "currentReplicas" separately
  3. there is a race condition where pod creation after the creation of the namespace can fail because a "default" serviceaccount is not yet ready/created in the newly created namespace (Creating a pod fails if default service account does not exist with the default service account enabled. kubernetes/kubernetes#66689) - need to wait for the serviceaccount to be ready

There are still more flaky tests, this only takes things a bit further

@sumedhpd sumedhpd requested a review from a team February 8, 2024 15:13
@sumedhpd sumedhpd marked this pull request as ready for review February 8, 2024 15:14
@sumedhpd sumedhpd requested a review from kn100 February 8, 2024 15:19
@sumedhpd sumedhpd marked this pull request as draft February 8, 2024 16:24
@sumedhpd
Copy link
Contributor Author

sumedhpd commented Feb 8, 2024

testing locally, it seems now there are far fewer flaky tests

@sumedhpd sumedhpd marked this pull request as ready for review February 8, 2024 23:25
@sumedhpd sumedhpd marked this pull request as draft February 9, 2024 00:09
@sumedhpd sumedhpd marked this pull request as ready for review February 9, 2024 01:26
@sumedhpd sumedhpd requested review from timothysmith0609, a team and kn100 February 9, 2024 01:27
Copy link
Contributor

@kn100 kn100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems sensible to me :D

Copy link
Contributor

@timothysmith0609 timothysmith0609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@sumedhpd
Copy link
Contributor Author

sumedhpd commented Feb 9, 2024

another CI with 0 retries needed :)

@sumedhpd sumedhpd merged commit d4ac4d0 into main Feb 9, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants