Don't execute i18n watcher on boot.

It shouldn't catch any file changes initially, and unnecessarily slows down boot of applications with lots of translations.
Shopify · Oct 10, 2024 · ab7b58b · ab7b58b
1 parent f1be11a
commit ab7b58b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/activesupport/CHANGELOG.md b/activesupport/CHANGELOG.md
@@ -1,3 +1,8 @@
+*   Don't execute i18n watcher on boot. It shouldn't catch any file changes initially,
+    and unnecessarily slows down boot of applications with lots of translations.
+
+    *Gannon McGibbon*
+
 *   Fix `ActiveSupport::HashWithIndifferentAccess#stringify_keys` to stringify all keys not just symbols.
 
     Previously:

diff --git a/activesupport/lib/active_support/i18n_railtie.rb b/activesupport/lib/active_support/i18n_railtie.rb
@@ -68,15 +68,14 @@ def self.initialize_i18n(app)
         directories = watched_dirs_with_extensions(reloadable_paths)
         root_load_paths = I18n.load_path.select { |path| path.to_s.start_with?(Rails.root.to_s) }
         reloader = app.config.file_watcher.new(root_load_paths, directories) do
-          I18n.load_path.delete_if { |p| p.to_s.start_with?(Rails.root.to_s) && !File.exist?(p) }
+          I18n.load_path.delete_if { |path| path.to_s.start_with?(Rails.root.to_s) && !File.exist?(p) }
           I18n.load_path |= reloadable_paths.flat_map(&:existent)
         end
 
         app.reloaders << reloader
         app.reloader.to_run do
           reloader.execute_if_updated { require_unload_lock! }
         end
-        reloader.execute
       end
 
       @i18n_inited = true