Fixes unchecked access of primitives.targets #227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exporting models from Maya I get meshes that look like (omitting attribute details for brevity):
Note that there is no
targets
property on the primitive and thetargetNames
extra is an empty array. The emptytargetNames
array makeshasTargetNames
(Assets/GLTFUtility/Scripts/Spec/GLTFMesh.cs:200) true causing a check for matching array lengths. The latter previously unconditionally accessedGLTFPrimitive.targets
which isnull
for this mesh, causing the mesh to not be imported.