Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guessit list alterante fix #8759

Merged
merged 4 commits into from
May 12, 2024
Merged

Guessit list alterante fix #8759

merged 4 commits into from
May 12, 2024

Conversation

BKSteve
Copy link
Collaborator

@BKSteve BKSteve commented May 12, 2024

Fix to convert guessit title returned as list to string at the origin of the problem.

This is an alternate to #8754 which I could replicate and possibly #8758 which couldn't be confirmed as yet to recieve sufficient data on cause to be able to replicate.

Chose to do here as it then reduces iterations rather than in helpers.py or tvdb.py code.

Copy link
Contributor

coderabbitai bot commented May 12, 2024

Walkthrough

The recent updates focus on improving the postProcessor class to handle title data presented as a list, converting it to a string when necessary. Additionally, unnecessary code, like an unused logger import, has been removed from tvdb.py, streamlining the codebase.

Changes

File Path Change Summary
.../postProcessor.py Enhanced handling of title as a list by converting to string; updated guessit_findit function.
.../indexers/tvdb.py Removed unused logger import.
pyproject.toml Updated pytest dependency version constraint excluding 8.2.0 and added filterwarnings option.

🐇✨
In the realm of code, where bugs often hide,
A rabbit hopped through, with changes to bide.
Titles as lists, no more a fuss,
Clean and streamlined, much better for us.
Hop, hop, hooray, for cleaner code today! 🌟
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between bb9c1af and ef443cc.
Files selected for processing (2)
  • sickchill/oldbeard/postProcessor.py (1 hunks)
  • sickchill/show/indexers/tvdb.py (1 hunks)
Additional Context Used
Ruff (1)
sickchill/show/indexers/tvdb.py (1)

190-190: Do not use bare except

Additional comments not posted (1)
sickchill/oldbeard/postProcessor.py (1)

1240-1245: The handling of title when it is a list by joining its elements with spaces is a good approach to ensure that the title is processed as a string. This change addresses the issue mentioned in the PR description effectively.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between ef443cc and 6f355e5.
Files selected for processing (1)
  • pyproject.toml (2 hunks)
Files skipped from review due to trivial changes (1)
  • pyproject.toml

@miigotu miigotu merged commit a4f2166 into develop May 12, 2024
11 checks passed
@miigotu miigotu deleted the guess2 branch May 12, 2024 13:03
@offbyone offbyone mentioned this pull request May 23, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants