[NEB-4777] Add KYC, geo, and bot-detection structured fields - #165
Open
rkumar-sift wants to merge 1 commit into
Open
[NEB-4777] Add KYC, geo, and bot-detection structured fields#165rkumar-sift wants to merge 1 commit into
rkumar-sift wants to merge 1 commit into
Conversation
mzobro-sift
reviewed
Aug 27, 2026
| " \"$year_of_birth\" : 1985,\n" + | ||
| " \"$kyc\" : {\n" + | ||
| " \"$names_match\" : true,\n" + | ||
| " \"$kyc_level\" : \"basic\",\n" + |
There was a problem hiding this comment.
the values should have the '$' prefix. Here and in other places
| " \"$provider\" : \"geocomply\"\n" + | ||
| " },\n" + | ||
| " \"$bot_identification\" : {\n" + | ||
| " \"$result\" : \"human\",\n" + |
There was a problem hiding this comment.
the values should have the '$' prefix, as it's enum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add support for the new structured fields (
$nationality,$year_of_birth,$kyc,$geo,$bot_identification) per the Structured Fields TDD (NEB-4573).Summary
Kyc,Geo,BotIdentificationundercom.siftscience.model.BaseAccountFieldSet,VerificationFieldSet($kyconly),TransactionFieldSet,BaseOrderFieldSet,LoginFieldSet($geo/$bot_identificationonly).$kyc_level,$bot_identification.$result) use$-prefixed string values, consistent with other enum fields in this API (e.g.$login_status).CHANGES.MD/README.mdupdated.Testing
Follow-up (tracked separately, not in this PR): structured-fields coverage in
sift-java-integration-appis deferred until the server-side schema change (NEB-4775) is live in production — it isn't yet.