Kcov zig 4merge (for discussion) #424
Conversation
for zig, it will mark unreachable/@Panic lines as uncover for c/cpp, need to manual mark with "/* no-cover */"
…t number after ignoring no cover lines
|
|
||
| Here is a screenshot of auto ignoring `unreachable`. | ||
|
|
||
|  |
There was a problem hiding this comment.
All this is nice information, but when "native" kcov supports it, I think it won't be needed (as it's shown in the output anyway).
There was a problem hiding this comment.
agree, I will remove this in later cleaned up PR.
|
|
||
| after building is done. The binary is at `build/src/kcov`. Copy somewhere and use it. | ||
|
|
||
| (Or you can download a copy of Apple Silicon version binary from the release section.) |
There was a problem hiding this comment.
I think we can make a release shortly after merge of this, and then the osx homebrew is usually updated quite quickly.
I suppose that can be added to the README, or another documentation file. Since not all distributions are up to date, I don't want to in general recommend installing from there.
| @@ -134,6 +135,12 @@ class CodecovWriter : public WriterBase | |||
| IReporter::LineExecutionCount cnt = m_reporter.getLineExecutionCount(file->m_name, n); | |||
| std::string hitScore = "0"; | |||
|
|
|||
| std::string& line_str = file->m_lineMap.at(n); | |||
There was a problem hiding this comment.
Kcov now builds with c++17, so you can use auto & for these.
| nTotalExecutedLines += summary.m_executedLines; | ||
| nTotalCodeLines += inFilesTotalCodeLines; | ||
| nTotalExecutedLines += inFilesTotalExecutedLines; | ||
| // nTotalCodeLines += summary.m_lines; |
| summary.m_executedLines); | ||
| std::string datum = getIndexHeader(fmt("%s/index.html", de->d_name), name, name, inFilesTotalCodeLines, | ||
| inFilesTotalExecutedLines); | ||
| // std::string datum = getIndexHeader(fmt("%s/index.html", de->d_name), name, name, summary.m_lines, |
|
|
||
| const std::string& line_str = file->m_lineMap[n]; | ||
| const std::string& file_name = it->first; | ||
| bool should_cover = shouldCover(line_str, file_name); |
There was a problem hiding this comment.
I think that all these can probably be moved to reporter.cc instead, to the lineIsCode method. I.e., you could do something like shouldCover(...) && it->second->lineIsCode(...) there, and then you can probably remove all changes to the writers.
At least it's something to try out.
| } | ||
|
|
||
| FileType getFileExt(const std::string& file_name) { | ||
| const std::string zig_ending = ".zig"; |
There was a problem hiding this comment.
here you could also write this as
constexpr auto relevant_extensions = std::array {
std::pair{".c", c},
[...]
};
for (const auto &[ending, extension])
{
if (endsWith(..., ending)
{
return extension;
}
}
#423
a preview of core changes to kcov for discussion