Merge pull request #248 from Simperium/issue/sqlblobtoobig

Check for SQLException when getting object from SQLite storage

Simperium/src/main/java/com/simperium/client/Bucket.java

@@ -22,6 +22,7 @@
 
 import android.database.Cursor;
 import android.database.CursorWrapper;
+import android.database.SQLException;
 
 import androidx.core.util.Consumer;
 
@@ -513,7 +514,18 @@ public T get(String key) throws BucketObjectMissingException {
         } catch (GhostMissingException e) {
             throw(new BucketObjectMissingException(String.format("Bucket %s does not have object %s", getName(), key)));
         }
-        T object = mStorage.get(key);
+
+        // Check if there isn't an SQLException (e.g. SQLiteBlobTooBigException) to avoid propagating an unchecked
+        // exception.
+        // Note: this check should be at the storage level since at the Bucket level we don't know that we are dealing
+        // with a SQLite storage. However, at this point we have more information about what is happening, thus, it can
+        // be better reported.
+        T object;
+        try {
+            object = mStorage.get(key);
+        } catch (SQLException e) {
+            throw(new BucketObjectMissingException(String.format("Bucket %s does not have object %s", getName(), key), e));
+        }
         if (object == null) {
             throw(new BucketObjectMissingException(String.format("Storage provider for bucket:%s did not have object %s", getName(), key)));
         }