-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random Bark Revamp #1003
Merged
VMSolidus
merged 5 commits into
Simple-Station:master
from
Mnemotechnician:tweak/random-bark-is-not-literal-bark
Oct 9, 2024
Merged
Random Bark Revamp #1003
VMSolidus
merged 5 commits into
Simple-Station:master
from
Mnemotechnician:tweak/random-bark-is-not-literal-bark
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: C#
Changes any cs files
Changes: Localization
Changes any ftl files
Changes: YML
Changes any yml files
labels
Oct 3, 2024
FoxxoTrystan
added
Size: 4-Small
For small issues/PRs
Priority: 3-Medium
Needs to be resolved at some point
labels
Oct 3, 2024
FoxxoTrystan
requested review from
a team,
VMSolidus,
FoxxoTrystan,
DEATHB4DEFEAT,
Peptide90,
Pspritechologist and
OldDanceJacket
and removed request for
a team
October 3, 2024 20:03
FoxxoTrystan
requested changes
Oct 3, 2024
Co-authored-by: FoxxoTrystan <45297731+FoxxoTrystan@users.noreply.github.com> Signed-off-by: Mnemotechnican <69920617+Mnemotechnician@users.noreply.github.com>
Ugh, I forgot some bark types. I'll uh, add them later. |
FoxxoTrystan
previously requested changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, Test fails valid.
FoxxoTrystan
added
Status: Awaiting Changes
Do not merge due to requested changes
and removed
Status: Needs Review
Someone please review this
labels
Oct 3, 2024
github-actions
bot
added
Status: Needs Review
Someone please review this
and removed
Status: Awaiting Changes
Do not merge due to requested changes
labels
Oct 4, 2024
VMSolidus
approved these changes
Oct 9, 2024
OldDanceJacket
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: C#
Changes any cs files
Changes: Localization
Changes any ftl files
Changes: YML
Changes any yml files
Priority: 3-Medium
Needs to be resolved at some point
Size: 4-Small
For small issues/PRs
Status: Needs Review
Someone please review this
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves the random barks by:
This also reparents MobSecurityDog to MobCorgi and MobArcticFox to MobFox because for some reason delta-v decided to copy the original mobs instead of using inheritance??? Either way, laika and siobhan will now also have random barks, can be carried, etc.
Media
Changelog
🆑