Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Bark Revamp #1003

Conversation

Mnemotechnician
Copy link
Contributor

Description

This improves the random barks by:

  • Fully moving the random barks to localization files, with the ability to re-use existing types
  • Adding many new (english) random bark types
  • Making the random bark system add a random punctuation mark at the end of a random bark
  • Adjusting some existing random bark configs

This also reparents MobSecurityDog to MobCorgi and MobArcticFox to MobFox because for some reason delta-v decided to copy the original mobs instead of using inheritance??? Either way, laika and siobhan will now also have random barks, can be carried, etc.

Media

image
image
image
image

Changelog

🆑

  • add: Animals now have more unique things to say when not controlled by a player.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Oct 3, 2024
@SimpleStation14 SimpleStation14 changed the title Random bark revamp Random Bark Revamp Oct 3, 2024
@FoxxoTrystan FoxxoTrystan added Size: 4-Small For small issues/PRs Priority: 3-Medium Needs to be resolved at some point labels Oct 3, 2024
@FoxxoTrystan FoxxoTrystan requested review from a team, VMSolidus, FoxxoTrystan, DEATHB4DEFEAT, Peptide90, Pspritechologist and OldDanceJacket and removed request for a team October 3, 2024 20:03
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Oct 3, 2024
Co-authored-by: FoxxoTrystan <45297731+FoxxoTrystan@users.noreply.github.com>
Signed-off-by: Mnemotechnican <69920617+Mnemotechnician@users.noreply.github.com>
@Mnemotechnician
Copy link
Contributor Author

Ugh, I forgot some bark types. I'll uh, add them later.

Copy link
Member

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, Test fails valid.

@FoxxoTrystan FoxxoTrystan added Status: Awaiting Changes Do not merge due to requested changes and removed Status: Needs Review Someone please review this labels Oct 3, 2024
@github-actions github-actions bot added Status: Needs Review Someone please review this and removed Status: Awaiting Changes Do not merge due to requested changes labels Oct 4, 2024
@VMSolidus VMSolidus merged commit 14d2280 into Simple-Station:master Oct 9, 2024
12 checks passed
SimpleStation14 added a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 4-Small For small issues/PRs Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants