Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some Locales Seemingly Made Using Google Translate #1006

Merged
merged 3 commits into from
Oct 5, 2024
Merged

Fix some Locales Seemingly Made Using Google Translate #1006

merged 3 commits into from
Oct 5, 2024

Conversation

Mnemotechnician
Copy link
Contributor

@Mnemotechnician Mnemotechnician commented Oct 4, 2024 •
edited
Loading

Description

How did this pass code review?

Media

image

image

Changelog

N/A

@Mnemotechnician
Update ghost-respawn.ftl
a98c90f 
Signed-off-by: Mnemotechnican <69920617+Mnemotechnician@users.noreply.github.com>
@github-actions github-actions bot added the Changes: Localization Changes any ftl files label Oct 4, 2024
@SimpleStation14 SimpleStation14 changed the title Fix some locales seemingly made using google translate Fix some Locales Seemingly Made Using Google Translate Oct 4, 2024
@stellar-novas
Copy link
Contributor

No one reads locales

stellar-novas
stellar-novas suggested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@stellar-novas stellar-novas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think respawn as a term is confusing. I think "return to the round" is clunky.

Resources/Locale/en-US/ghost/ghost-respawn.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/ghost/ghost-respawn.ftl Outdated Show resolved Hide resolved
stellar-novas
stellar-novas suggested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@stellar-novas stellar-novas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't save all my comments :agony:

Resources/Locale/en-US/ghost/ghost-respawn.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/ghost/ghost-respawn.ftl Outdated Show resolved Hide resolved
@Mnemotechnician @stellar-novas
Apply suggestions from code review
cfa6842 
Co-authored-by: stellar-novas <stellar_novas@riseup.net>
Signed-off-by: Mnemotechnican <69920617+Mnemotechnician@users.noreply.github.com>
@Mnemotechnician
Copy link
Contributor Author

I don't think respawn as a term is confusing. I think "return to the round" is clunky.

Fair I suppose

@github-actions github-actions bot added the Status: Needs Review Someone please review this label Oct 4, 2024
@FoxxoTrystan FoxxoTrystan added Priority: 3-Medium Needs to be resolved at some point Size: 5-Very Small For especially small issues/PRs labels Oct 4, 2024
@Mnemotechnician
oops
a46e567 
Signed-off-by: Mnemotechnican <69920617+Mnemotechnician@users.noreply.github.com>
@VMSolidus VMSolidus merged commit 1c6c0bd into Simple-Station:master Oct 5, 2024
10 checks passed
@Spatison Spatison mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellar-novas stellar-novas stellar-novas requested changes

@VMSolidus VMSolidus VMSolidus approved these changes

@Peptide90 Peptide90 Peptide90 approved these changes

@FoxxoTrystan FoxxoTrystan Awaiting requested review from FoxxoTrystan

@DEATHB4DEFEAT DEATHB4DEFEAT Awaiting requested review from DEATHB4DEFEAT

@Pspritechologist Pspritechologist Awaiting requested review from Pspritechologist

@OldDanceJacket OldDanceJacket Awaiting requested review from OldDanceJacket

@NotScoutieBoi NotScoutieBoi Awaiting requested review from NotScoutieBoi

Assignees

@Mnemotechnician Mnemotechnician

Labels
Changes: Localization Changes any ftl files Priority: 3-Medium Needs to be resolved at some point Size: 5-Very Small For especially small issues/PRs Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mnemotechnician @stellar-novas @VMSolidus @Peptide90 @FoxxoTrystan