Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Musician Loadouts #1108

Merged
merged 3 commits into from
Oct 20, 2024
Merged

Conversation

VMSolidus
Copy link
Member

Description

Fixes #1103
This PR removes the default saxophone and acoustic guitar that the Musician spawns with. Instead the Musician now has a selection of 3 free picks of almost any instrument in the game. The only instruments not included in his list are the Supersynth, DAW, and admeme items such as the "Musical Lung" and "Fingerless Frets". There's a few instruments leftover for the Clown that will be given to the clown in his own separate PR.

To make sure the musicians can also take large instruments, this PR also takes a feature from Frontier, that of "InstrumentFlatpacks", and adds them to the musician loadouts. So Musicians can take for instance a Minimoog flatpack if they so desire.

Media

image

Changelog

🆑

  • add: Musicians can now select for free, any 3 instruments in the game with their loadout. This now includes things like Piano flatpacks. The only instruments not included are the Sypersynth, DAW, and "Admeme Instruments".
  • remove: Musicians no longer spawn with a Saxophone and Acoustic guitar by default. You pick which instruments you spawn with in your loadouts now.

@github-actions github-actions bot added Changes: Localization Changes any ftl files Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an RSI labels Oct 20, 2024
Copy link
Contributor

RSI Diff Bot; head commit 95c6cfc merging into 6d376a7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Devices/flatpack.rsi

State Old New Status
service_music Added

@VMSolidus VMSolidus merged commit e56f6a9 into Simple-Station:master Oct 20, 2024
14 checks passed
VMSolidus pushed a commit to VMSolidus/Einstein-Engines that referenced this pull request Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Musician Job not spawning with default Instruments on Round Start.
3 participants