Station Only Glimmer Mites #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mnemotechnician
suggested changes
Sep 29, 2024
Content.Server/DeltaV/StationEvents/Events/GlimmerMobSpawnRule.cs
Outdated
Show resolved
Hide resolved
Content.Server/DeltaV/StationEvents/Events/GlimmerMobSpawnRule.cs
Outdated
Show resolved
Hide resolved
Content.Server/DeltaV/StationEvents/Events/GlimmerMobSpawnRule.cs
Outdated
Show resolved
Hide resolved
FoxxoTrystan
requested review from
a team,
DEATHB4DEFEAT,
FoxxoTrystan,
Peptide90,
Pspritechologist and
OldDanceJacket
and removed request for
a team
FoxxoTrystan
added
Priority: 2-High
FoxxoTrystan
added
Priority: 1-Urgent
FoxxoTrystan
approved these changes
Oct 7, 2024
|
As suggested above (but ignored by VM), stations should never be hardcoded. This WILL break if someone adds more than 1 station to a map (which is perfectly possible and fine, see: frontier; or the new wizden map which evidently contains 2 stations), or if the original station loses its station status, or under many other different conditions. |
|
Alright fine, it no longer assumes only one spawnable station. |
OldDanceJacket
approved these changes
Oct 9, 2024
SimpleStation14
added a commit
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it so that Glimmer Mites can only spawn on "The Main Station", as defined by GetSpawnableStations. Yes this is seemingly pretty hardcodey, but because on our codebase it's simply not possible for GetSpawnableStations to ever return anything other than a list with an index of 0, we can extremely reliably count on GetSpawnableStations()[0] to be "THE Station".
This fixes an issue whereby Glimmer Mites can spawn in places where it is simply not possible for players to reach them. Such as random asteroids in space, CENTCOMM, Nukie World, or the Syndicate Listening Outpost.
Changelog
🆑