Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove misleading ImageInfo inheritance note #63

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Remove misleading ImageInfo inheritance note #63

merged 1 commit into from
Sep 22, 2023

Conversation

agc93
Copy link
Contributor

@agc93 agc93 commented Sep 22, 2023

The docs claim that Image<TPixel> implements ImageInfo, but the source for Image<TPixel> suggests otherwise.

@CLAassistant
Copy link

CLAassistant commented Sep 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JimBobSquarePants
Copy link
Member

Thanks yeah. That's a mistake. Image<TPixel> used to inherit IImageInfo in V2.

@JimBobSquarePants JimBobSquarePants merged commit 0ccf070 into SixLabors:main Sep 22, 2023
2 of 3 checks passed
@agc93 agc93 deleted the fix/imageinfo-inheritance branch September 22, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agc93 @CLAassistant @JimBobSquarePants