KOA-5584: Migrating bpk-stylesheets and bpk-mixins to backpack web #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anambl
reviewed
Jul 18, 2023
| /dist-storybook | ||
| node_modules | ||
| npm-debug.* | ||
| lerna-debug.log | ||
| sassdoc-data.json |
There was a problem hiding this comment.
This wasn't used anywhere, right?
anambl
requested changes
Aug 3, 2023
There was a problem hiding this comment.
Just realised now, we should be removing the stories for the mixins? We don't need them anymore anyways as it's just typography anyways for which we already have stories in backpack-web which are better as they are actually directly used on the BpkText component 🤔
olliecurtis
force-pushed
the
KOA-5884-migrating-packages
branch
3 times, most recently
from
d58b45b
to
af3d7bb
Compare
olliecurtis
force-pushed
the
KOA-5884-migrating-packages
branch
from
af3d7bb
to
c92d1e4
Compare
anambl
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of wanting to secure our packages to a scoped organisation for security and management, we also found that for ease of consumer use we have migrated over
bpk-mixinsandbpk-stylesheetsto github.com/skyscanner/backpackThis improves dependency management as they are bundled together instead of separately so less likely for dependency tress to be out of sync.
Remember to include the following changes:
UNRELEASED.md(See How to write a good changelog entry)README.md