Add @stylistic/eslint-plugin and enforce formatting rules - #104
Closed
heavyrubberslave wants to merge 15 commits into
Closed
Add @stylistic/eslint-plugin and enforce formatting rules#104heavyrubberslave wants to merge 15 commits into
heavyrubberslave wants to merge 15 commits into
Conversation
|
Important Review skippedToo many files! This PR contains 192 files, which is 92 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (192)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
heavyrubberslave
force-pushed
the
chore/stylistic-formatting-rules
branch
from
August 5, 2026 22:34
4542f8f to
52d45aa
Compare
- Add @stylistic/eslint-plugin dependency and stylistic.configs.recommended - Configure indent (4 spaces), semi (always), comma-dangle (always-multiline) - Configure member-delimiter-style (semi for multiline, comma for singleline) - Configure operator-linebreak (before, with = kept after for multiline type declarations) - Configure indent-binary-ops (4 spaces, matching general indent) - Configure arrow-parens (as-needed, no exception for block bodies) - Require blank line between type/interface/class/enum declarations and a following export statement - Disable brace-style (mixed Allman/1tbs convention not configurable via a single rule)
waitForNextWsEvent(deviceRefreshed) had no predicate, so it could resolve on the device's own 175ms auto-refresh tick instead of the refresh actually caused by the channelALevel update, letting the assertion run before 'A80' was written to the device.
heavyrubberslave
force-pushed
the
chore/stylistic-formatting-rules
branch
from
August 7, 2026 15:31
778a488 to
a8a3c56
Compare
…l, no-unused-expressions)
heavyrubberslave
marked this pull request as ready for review
August 8, 2026 20:59
Member
Author
|
Close in favor of #108 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@stylistic/eslint-pluginand enablesstylistic.configs.recommendedmember-delimiter-style(semi for multiline type members, comma for single-line)operator-linebreak(before, with=kept after for multiline type declarations)indent-binary-ops(4 spaces, matching general indent)arrow-parens(as-needed, no exception for block bodies)type/interface/class/enumdeclarations and a followingexportstatementbrace-style(codebase mixes Allman for class/constructor declarations and 1tbs for control-flow, not expressible via this rule's single-style options)