Skip to content

Commit

Permalink
feat(redmine 1306612): correction to color contrast
Browse files Browse the repository at this point in the history
  • Loading branch information
Meriemu committed Aug 6, 2024
1 parent 81ba004 commit 932eb12
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/curvy-zoos-stare.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@smile/haring-react': minor
---

make corrections to color contrasts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const meta = {
</Badge>
</Group>

<Text color="dimmed" size="sm">
<Text c="dark.3" size="sm">
With Fjord Tours you can explore more of the magical fjord
landscapes with tours and activities on and around the fjords of
Norway
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
import type { Meta, StoryObj } from '@storybook/react';

import { DEFAULT_THEME } from '@mantine/core';

import { DataBadge as Cmp } from './DataBadge';

const colorOptions = Object.keys(DEFAULT_THEME.colors);
const meta = {
argTypes: {
color: {
control: { type: 'color' },
control: 'select',
options: colorOptions,
},
},
component: Cmp,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,13 @@ const meta = {

export default meta;
type IStory = StoryObj<typeof meta>;
const customPrimaryTheme = {
...primaryTheme,
colors: {
dark: ['#1E0303'],
...primaryTheme.colors,
},
};

export const Header: IStory = {
args: {
Expand All @@ -66,7 +73,7 @@ export const Header: IStory = {
},
onSearchSubmit: action('search input submitted'),
right: rightContentMock,
searchTheme: primaryTheme,
searchTheme: customPrimaryTheme,

Check failure on line 76 in packages/haring-react/src/Components/Header/Header.stories.tsx

View workflow job for this annotation

GitHub Actions / test

Type '{ colors: { blue?: MantineColorsTuple | undefined; cyan?: MantineColorsTuple | undefined; gray?: MantineColorsTuple | undefined; ... 10 more ...; grape?: MantineColorsTuple | undefined; }; ... 26 more ...; other?: PartialObjectDeep<...> | undefined; }' is not assignable to type 'PartialObjectDeep<MantineTheme, {}>'.
searchValue: '',
withBorder: false,
},
Expand Down

0 comments on commit 932eb12

Please sign in to comment.