-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(redmine 1246926): hasOnlyOneOpenMenu option for SidebarMenu, added utilities #13
Conversation
🦋 Changeset detectedLatest commit: 1e094d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bfb467c
to
8af25cf
Compare
…ed utilities refactor: reworked CollapseButton into Uncontrolled and Controlled versions refactor: modified CollapseButton stories, added expanded detail to stories (desc and default columns)
8af25cf
to
8c712a1
Compare
packages/react-front-kit/src/3-custom/Components/CollapseButton/CollapseButton.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-front-kit/src/3-custom/Components/SidebarMenu/SidebarMenu.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-front-kit/src/3-custom/Components/SidebarMenu/SidebarMenu.tsx
Show resolved
Hide resolved
@tonai J'ai ajusté selon tes commentaires. Je suis aussi passé sur les components existants pour rajouter la ligne Par contre problème, pour le cas spécifique de la seconde story de J'ai linté le tout est ça a modifié légèrement |
Peux-tu tester si tu as le même problème en créant 2 fichiers .stories (un pour chaque composant, et donc une doc pour chaque composant) |
packages/react-front-kit/src/3-custom/Components/CollapseButton/CollapseButton.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-front-kit/src/3-custom/Components/SidebarMenu/SidebarMenu.tsx
Outdated
Show resolved
Hide resolved
Yep, ça fonctionne comme ça. Tant que l'autre fichier est du même nom que la story qu'il contient (ici le fichier et sa story son Non seulement maintenant la description marche mais ça détecte correctement les |
…ed utilities (#13) * feat(redmine 1246926): hasOnlyOneOpenMenu option for SidebarMenu, added utilities refactor: reworked CollapseButton into Uncontrolled and Controlled versions refactor: modified CollapseButton stories, added expanded detail to stories (desc and default columns)
refactor: reworked CollapseButton into Uncontrolled and Controlled versions
refactor: modified CollapseButton stories, added expanded detail to stories (desc and default columns)