feat: #1246947 added Pagination component #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Est-ce que pour le commit on ne mettrais pas le numéro du ticket dans le scope ? |
tonai
reviewed
Aug 31, 2023
packages/react-front-kit/src/3-custom/Components/Pagination/Pagination.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-front-kit/src/3-custom/Components/Pagination/Pagination.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-front-kit/src/3-custom/Components/Pagination/Pagination.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-front-kit/src/3-custom/Components/Pagination/Pagination.tsx
Show resolved
Hide resolved
packages/react-front-kit/src/3-custom/Components/Pagination/Pagination.tsx
Outdated
Show resolved
Hide resolved
packages/react-front-kit/src/3-custom/Components/Pagination/Pagination.tsx
Outdated
Show resolved
Hide resolved
packages/react-front-kit/src/3-custom/Components/Pagination/Pagination.tsx
Outdated
Show resolved
Hide resolved
packages/react-front-kit/src/3-custom/Components/Pagination/Pagination.tsx
Show resolved
Hide resolved
vapersmile
previously approved these changes
Aug 31, 2023
tonai
reviewed
Aug 31, 2023
packages/react-front-kit/src/3-custom/Components/Pagination/Pagination.tsx
Show resolved
Hide resolved
QuentinLeCaignec
force-pushed
the
feature/1246947_pagination
branch
from
e8a5cbd
to
3129cb6
Compare
QuentinLeCaignec
force-pushed
the
feature/1246947_pagination
branch
from
3129cb6
to
149e154
Compare
tonai
previously requested changes
Sep 4, 2023
packages/react-front-kit/src/3-custom/Components/Pagination/Pagination.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-front-kit/src/3-custom/Components/Pagination/Pagination.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-front-kit/src/3-custom/Components/Pagination/Pagination.test.tsx
Show resolved
Hide resolved
tonai
reviewed
Sep 5, 2023
QuentinLeCaignec
dismissed
tonai’s stale review
Je doit refuser à cause de la suggestion de code qui bloque
tonai
approved these changes
Sep 6, 2023
tonai
pushed a commit
that referenced
this pull request
Sep 20, 2023
* feat(redmine 1246947): added Pagination component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Pagination component (+ test and story), added @storybook/preview-api dependency for story