Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build app #39

Merged
merged 1 commit into from
Oct 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ Private integration testing packages:

At the root level you can launch following commands:

- `npm run build`: Builds all sub projects
- `npm run dev`: Launches dev command in all sub projects
- `npm run build`: Builds all packages projects
- `npm run build:app`: Builds all apps projects
- `npm run dev`: Launches dev command in apps projects
- `npm run start`: Launches start command in apps projects
- `npm run lint`: Lints everything
- `npm run lint:root`: Lints everything but the `apps` folder
- `npm run lint:fix`: Lints and fix everything but the `apps` folder
Expand Down Expand Up @@ -89,8 +91,8 @@ To create a changeset:
2. This will create a changeset file in the `.changeset` folder you can review
3. Commit the changeset file

## Publishing
## Release

When a PR containing changesets is merged into `main` it will automatically create a release PR.
When a PR containing changesets is merged into `*.x` branch it will automatically create a release PR.

Then when that release PR is merged into `main`, it will automatically create a release and publish the packages on `npm`.
Then when that release PR is merged into the `*.x` branch, it will automatically create a release and publish the packages on `npm`.
2 changes: 1 addition & 1 deletion apps/next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"private": true,
"scripts": {
"dev": "next dev",
"build": "next build",
"build:app": "next build",
"start": "next start",
"lint": "next lint"
},
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"scripts": {
"prepare": "husky install",
"build": "turbo run build",
"build:app": "turbo run build:app",
"dev": "turbo run dev",
"lint": "turbo run lint && npm run lint:root",
"lint:root": "DEBUG=eslint:cli-engine eslint --max-warnings=0 --ignore-path <(cat .gitignore .eslintignore) . && tsc --noEmit",
Expand Down
6 changes: 5 additions & 1 deletion turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@
"pipeline": {
"build": {
"dependsOn": ["^build"],
"outputs": [".next/**", "!.next/cache/**", "dist"]
"outputs": ["dist"]
},
"build:app": {
"dependsOn": ["build"],
"outputs": [".next/**", "!.next/cache/**"]
},
"dev": {
"cache": false,
Expand Down