Issue #128 - Using campaign and site instead of site_name, site_id, p… #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jomey
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Just FYI:
I have a bigger PR coming with the restructure of ponits and image data. The changes to the API with this PR will probably have to get a close second look and a bit tricky to merge in. So maybe we can hold off on more PRs until I have that wrapped up (hopefully today)
|
Another thought is to wait with these changes and do them based off the re-worked coded base (#156) since they are smaller. Open to suggestions here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #128
Using campaign and site instead of site, site_id, pit_id
Now a campaign is the larger area like Grand Mesa
and a site is equivalent to a pit. So site.name is equivalent to pit_id