Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuing to streamline style usage #551

Merged
merged 19 commits into from
Dec 1, 2023
Merged

Continuing to streamline style usage #551

merged 19 commits into from
Dec 1, 2023

Conversation

timea-solid
Copy link
Member

@timea-solid timea-solid commented Jul 1, 2023

This work concludes this Issue #533 :

  • move almost all styles to style.js from each file. and fixed some typos in the process. (point 4 on the issue list).
  • streamline also styles in use with ns.ui('style') or ns.ui('background') (point 3 on the list)

Now we can start talking about changing the UI style.

@timea-solid timea-solid changed the title Continuing to stramline stlye usage Continuing to streamline style usage Jul 1, 2023
Copy link
Contributor

@SharonStrats SharonStrats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
my only thought is about the dist folder. I'm wondering if you should remove those files.

Copy link
Contributor

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, human-facing

src/media/media-capture.ts Outdated Show resolved Hide resolved
src/media/media-capture.ts Outdated Show resolved Hide resolved
src/pad.ts Outdated Show resolved Hide resolved
src/pad.ts Outdated Show resolved Hide resolved
src/participation.ts Outdated Show resolved Hide resolved
src/styleConstants.js Outdated Show resolved Hide resolved
src/widgets/dragAndDrop.js Outdated Show resolved Hide resolved
src/widgets/dragAndDrop.js Outdated Show resolved Hide resolved
src/widgets/dragAndDrop.js Outdated Show resolved Hide resolved
src/widgets/dragAndDrop.js Outdated Show resolved Hide resolved
timea-solid and others added 13 commits August 16, 2023 09:57
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@bourgeoa bourgeoa merged commit 8782737 into main Dec 1, 2023
10 checks passed
@bourgeoa bourgeoa deleted the styleStreamline branch December 1, 2023 19:52
@bourgeoa
Copy link
Contributor

bourgeoa commented Dec 3, 2023

@timea-solid could you look at this issue ?
image

@bourgeoa
Copy link
Contributor

bourgeoa commented Dec 3, 2023

This is the issue

rootElement.style.flexDirection = (vertical ? 'row' : 'column') + (flipped ? '-reverse;' : ';')

and I don't understand why. The evaluation is not done correctly

I tried here and It does not work also when using our function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants