Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdk format, net5 net6 net7 build target, test for new build target #15

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tqk2811
Copy link

@tqk2811 tqk2811 commented Aug 14, 2023

Change Log

  • Upgrade to NET SDK
  • Add TargetFrameworks: net5.0-windows7.0 net6.0-windows7.0 net7.0-windows7.0
  • Make test work for Net5 and higher

Test

image

Why test count difference
and

AutoGridSample

net7.0-windows7.0
image
image

@tqk2811 tqk2811 changed the title net5 net6 net7 build target Sdk format, net5 net6 net7 build target, test for new build target Aug 15, 2023
@jcummings2
Copy link

This PR looks good to me. I'd like more recent .Net support as well without the warnings mentioned in issue #13. Based on PR #14, the original author was trying to migrate to github actions for Continuous Integration (CI) but isn't able to give as much attention to this project anymore.

@tqk2811 I notice that you have another branch that is a start on a nuget package. It didn't appear that it used a CI of any kind but is that something you know how to add? In any case, is your nuget package something you can publish for public consumption?

@tqk2811
Copy link
Author

tqk2811 commented Dec 1, 2023

I notice that you have another branch that is a start on a nuget package. It didn't appear that it used a CI of any kind but is that something you know how to add? In any case, is your nuget package something you can publish for public consumption?

Yes, my private package for self use.

@jcummings2
Copy link

jcummings2 commented Dec 4, 2023

I notice that you have another branch that is a start on a nuget package. It didn't appear that it used a CI of any kind but is that something you know how to add? In any case, is your nuget package something you can publish for public consumption?

Yes, my private package for self use.

Great! Are you open to allowing this package to be public?

Along those lines, how about maintaining/releasing your forked version?

@tqk2811
Copy link
Author

tqk2811 commented Dec 5, 2023

I notice that you have another branch that is a start on a nuget package. It didn't appear that it used a CI of any kind but is that something you know how to add? In any case, is your nuget package something you can publish for public consumption?

Yes, my private package for self use.

Great! Are you open to allowing this package to be public?

Along those lines, how about maintaining/releasing your forked version?

Link nuget you can install it, private for disable search only
And for my repo, you can do anything (under SpicyTaco license)

@tqk2811
Copy link
Author

tqk2811 commented Jan 5, 2024

Along those lines, how about maintaining/releasing your forked version?

And I have no plans to maintain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants