Fix TLS support after tracing feature #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 22, 2024
pynipap/pynipap.py
Outdated
| from tracing import TracingXMLTransport, TracingXMLSafeTransport | ||
| if p.scheme == "http": | ||
| xml_transport = TracingXMLTransport | ||
| elif p.scheme == "https": |
| current_span.set_attribute("net.peer.port", connection.port) | ||
| current_span.set_attribute("net.peer.transport", "ip_tcp") | ||
| connection.putheader("traceparent", "00-" + hex(current_span.get_span_context().trace_id)[2:].zfill(32) + "-" + hex( | ||
| current_span.get_span_context().span_id)[2:].zfill(16) + "-01") |
There was a problem hiding this comment.
line too long (83 > 79 characters)
| current_span.set_attribute("net.peer.ip", connection.host) | ||
| current_span.set_attribute("net.peer.port", connection.port) | ||
| current_span.set_attribute("net.peer.transport", "ip_tcp") | ||
| connection.putheader("traceparent", "00-" + hex(current_span.get_span_context().trace_id)[2:].zfill(32) + "-" + hex( |
There was a problem hiding this comment.
line too long (132 > 79 characters)
| result = super().request(host, handler, request_body, verbose) | ||
| current_span.set_attribute("http.status_code", 200) | ||
| except xmlrpclib.ProtocolError as protocolError: | ||
| current_span.set_attribute("http.status_code", protocolError.errcode) |
There was a problem hiding this comment.
line too long (89 > 79 characters)
| with tracer.start_as_current_span("POST XML request", context.get_current(), SpanKind.CLIENT): | ||
| current_span = trace.get_current_span() | ||
| try: | ||
| result = super().request(host, handler, request_body, verbose) |
There was a problem hiding this comment.
line too long (82 > 79 characters)
| headers=headers, context=context) | ||
|
|
||
| def request(self, host, handler, request_body, verbose=False): | ||
| with tracer.start_as_current_span("POST XML request", context.get_current(), SpanKind.CLIENT): |
There was a problem hiding this comment.
line too long (106 > 79 characters)
| @@ -103,6 +103,39 @@ def send_content(self, connection, request_body): | |||
| current_span.get_span_context().span_id)[2:].zfill(16) + "-01") | |||
|
|
|||
| super().send_content(connection, request_body) | |||
|
|
|||
|
|
|||
| class TracingXMLSafeTransport(xmlrpclib.SafeTransport): | |||
The implementation of OpenTelemetry tracing broke TLS support in pynipap. This commit fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of OpenTelemetry tracing broke TLS support in pynipap. Fix.