Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add completions for empty strings, structs, and lists #1359

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

misode
Copy link
Member

@misode misode commented Jun 21, 2024

When there are no specific values available, suggests an empty string/struct/list. Still a draft because there are some cases where it only gives one of the options when in reality both a struct and list are allowed. And sometimes it doesn't show any completions.

image
image

image
image

Copy link
Contributor

@TheAfroOfDoom TheAfroOfDoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not to be too annoying about it but either a test or a blurb/example in the PR description would be helpful for those of us not super familiar with the intention/feature/bug etc. in-action (me)

(although this is still draft so maybe that was coming later 😄 )

@misode
Copy link
Member Author

misode commented Jun 21, 2024

We don't have any tests for completions right now, but I can attach a screenshot, sure 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants