Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Always perform "last read" check in heartbeat when HeartbeatConsisten…
…cyChecks is enabled (#2795) When we have slowly adding things to the heartbeat (originally intended just to send data to keep connections alive) like detecting connection health, the if/else has gotten more complicated. With the addition of HeartbeatConsistencyChecks, we prevented some fall throughs to later checks which means that if that option is enabled, we were no longer detecting dead sockets as intended. This is a tactical fix for the combination, but I think overall we should look at refactoring how this entire method works because shoehorning these things into the original structure/purpose has been problematic several times.
- Loading branch information