[Feature] Partial support of TDE in non-cloud-native rowset read/write #52179
+236
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
| const auto schema = _context.tablet_schema; | ||
| auto segment_writer = std::make_unique<SegmentWriter>(std::move(wfile), _num_segment, schema, _writer_options); | ||
| RETURN_IF_ERROR(segment_writer->init(column_indexes, is_key)); | ||
| DCHECK(_segment_encryption_metas.size() == _num_segment); | ||
| _segment_encryption_metas.emplace_back(_writer_options.encryption_meta); | ||
| ++_num_segment; | ||
| return std::move(segment_writer); | ||
| } |
There was a problem hiding this comment.
The most risky bug in this code is:
A potential race condition involving multiple threads accessing and modifying _segment_encryption_metas.
You can modify the code like this:
StatusOr<RowsetSharedPtr> RowsetWriter::build() {
std::lock_guard<std::mutex> l(_lock); // Protect access to _segment_encryption_metas
_rowset_meta_pb->set_empty(_num_rows_written == 0);
_rowset_meta_pb->set_creation_time(time(nullptr));
_rowset_meta_pb->set_num_segments(_num_segment);
DCHECK(_segment_encryption_metas.size() == _num_segment);
for (auto& encryption_meta : _segment_encryption_metas) {
_rowset_meta_pb->add_segment_encryption_metas(encryption_meta);
}
// additional relevant code...
}
// Add similar locking mechanisms where other concurrent accesses are made,
// such as during the invocations of _flush_segment,
// _flush_delete_file, _flush_update_file, _create_segment_writer, etc.This adjustment ensures thread safety by using a mutex to guard accesses to shared resources that may be modified concurrently, which helps prevent race conditions.
3 tasks
decster
force-pushed
the
tde-ncn
branch
3 times, most recently
from
1b0c031
to
6490d24
Compare
decster
changed the title
Signed-off-by: Binglin Chang <decstery@gmail.com>
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 105 / 131 (80.15%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I'm doing:
Some code in rowset read/write to support TDE in non-cloud-native
Fixes: #46223
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: