Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix client couldn't cancel forward query #52185

Merged
merged 1 commit into from
Oct 24, 2024
Merged

[BugFix] Fix client couldn't cancel forward query #52185

merged 1 commit into from
Oct 24, 2024
+272 −10

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Oct 22, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@wanpengfei-git wanpengfei-git requested a review from a team October 22, 2024 03:16
@stdpain stdpain force-pushed the fix_cannot_cancel_fowrard_query branch 2 times, most recently from 20d4df6 to 7cd1ea5 Compare October 22, 2024 05:50
@stdpain stdpain force-pushed the fix_cannot_cancel_fowrard_query branch 3 times, most recently from 76cc040 to bd2e636 Compare October 22, 2024 11:54
@stdpain
[BugFix] Fix client couldn't cancel forward query
cddfabd 
Signed-off-by: stdpain <drfeng08@gmail.com>
@stdpain stdpain force-pushed the fix_cannot_cancel_fowrard_query branch from bd2e636 to cddfabd Compare October 24, 2024 03:38
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 67 / 81 (82.72%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/StmtExecutor.java 11 20 55.00% [922, 923, 924, 925, 927, 1062, 1063, 1065, 1066]
🔵 com/starrocks/qe/ConnectContext.java 5 9 55.56% [594, 595, 597, 598]
🔵 com/starrocks/service/FrontendServiceImpl.java 14 15 93.33% [1128]
🔵 com/starrocks/qe/LeaderOpExecutor.java 1 1 100.00% []
🔵 com/starrocks/qe/ProxyContextManager.java 34 34 100.00% []
🔵 com/starrocks/qe/ConnectProcessor.java 2 2 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@kangkaisen kangkaisen merged commit cc3a33c into StarRocks:main Oct 24, 2024
60 of 63 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.3 label Oct 24, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Oct 24, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 24, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 24, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 24, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 24, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 24, 2024
@stdpain @mergify
[BugFix] Fix client couldn't cancel forward query (#52185)
0eeba11 
Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit cc3a33c)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/StmtExecutor.java
@mergify mergify bot mentioned this pull request Oct 24, 2024
Closed
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 24, 2024
@stdpain @mergify
[BugFix] Fix client couldn't cancel forward query (#52185)
8cf9d37 
Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit cc3a33c)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/ConnectContext.java
#	fe/fe-core/src/main/java/com/starrocks/qe/ConnectProcessor.java
#	fe/fe-core/src/main/java/com/starrocks/qe/LeaderOpExecutor.java
#	fe/fe-core/src/main/java/com/starrocks/qe/StmtExecutor.java
#	gensrc/thrift/FrontendService.thrift
@mergify mergify bot mentioned this pull request Oct 24, 2024
Closed
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 24, 2024
@stdpain @mergify
[BugFix] Fix client couldn't cancel forward query (#52185)
bead688 
Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit cc3a33c)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/ConnectContext.java
#	fe/fe-core/src/main/java/com/starrocks/qe/ConnectProcessor.java
#	fe/fe-core/src/main/java/com/starrocks/qe/LeaderOpExecutor.java
#	fe/fe-core/src/main/java/com/starrocks/qe/StmtExecutor.java
#	gensrc/thrift/FrontendService.thrift
@mergify mergify bot mentioned this pull request Oct 24, 2024
Closed
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 24, 2024
@stdpain @mergify
[BugFix] Fix client couldn't cancel forward query (#52185)
b5bb60e 
Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit cc3a33c)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/ConnectContext.java
#	fe/fe-core/src/main/java/com/starrocks/qe/ConnectProcessor.java
#	fe/fe-core/src/main/java/com/starrocks/qe/LeaderOpExecutor.java
#	fe/fe-core/src/main/java/com/starrocks/qe/StmtExecutor.java
#	fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java
#	gensrc/thrift/FrontendService.thrift
@mergify mergify bot mentioned this pull request Oct 24, 2024
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvin-celerdata alvin-celerdata alvin-celerdata left review comments

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@Seaven Seaven Seaven approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@stdpain stdpain

Labels
PROTO-REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stdpain @Seaven @kangkaisen @alvin-celerdata @wanpengfei-git