[Enhancement] adjust async-profile queue strategy #52236
+32
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
Signed-off-by: Murphy <mofei@starrocks.com>
murphyatwork
force-pushed
the
murph_opt_async_profile
branch
from
f3a8c28
to
1452385
Compare
|
Seaven
previously approved these changes
Oct 23, 2024
Signed-off-by: Murphy <mofei@starrocks.com>
Signed-off-by: Murphy <mofei@starrocks.com>
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 6 / 6 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
| */ | ||
| private static final ThreadPoolExecutor EXECUTOR = | ||
| ThreadPoolManager.newDaemonFixedThreadPool(Config.profile_process_threads_num, | ||
| Integer.MAX_VALUE, "profile-worker", false); | ||
| ThreadPoolManager.newDaemonCacheThreadPool( |
There was a problem hiding this comment.
so thread pool core size is 3/4 * all cpus, maximumPoolSize is 3 * All cpus? can you explain why you decide using these numbers
| @@ -256,7 +258,7 @@ public boolean isFinished() { | |||
| } | |||
|
|
|||
| public boolean addListener(Consumer<Boolean> task) { | |||
| if (EXECUTOR.getQueue().size() > Config.profile_process_blocking_queue_size) { | |||
| if (EXECUTOR.getQueue().remainingCapacity() <= 0) { | |||
There was a problem hiding this comment.
so only 'corePoolSize' threads will be created? because when queue is full ,we change to sync profile mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Async profileuses a background threadpool to process profile, but it's configuration doesn't make sense for some intensive workload.thread_num: default is 2queue_size:thread_num * 128, too largeFor a typical workload:
100 / (1/0.2)=20threads to catchup the query profileWhat I'm doing:
Change the threadpool of
profile-worker:thread_num: max ascpu_cores*0.75queue_size: max asthread_num*4For the above workload:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: