Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix tablet meta use tabletMeta uses partition_id and physical_partition_id at the same time to cause confusion #52258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

meegoo
Copy link
Contributor

@meegoo meegoo commented Oct 23, 2024

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@meegoo meegoo requested a review from a team as a code owner October 23, 2024 22:58
@mergify mergify bot assigned meegoo Oct 23, 2024
@meegoo meegoo changed the title [BugFix] Fix tablet meta use tabletMeta uses partition_id and physica… [BugFix] Fix tablet meta use tabletMeta uses partition_id and physical_partition_id at the same time to cause confusion Oct 23, 2024
@meegoo meegoo requested a review from a team as a code owner October 23, 2024 23:45
…l_partition_id at the same time to cause confusion

Signed-off-by: meegoo <meegoo.sr@gmail.com>
Copy link

sonarcloud bot commented Oct 24, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 130 / 153 (84.97%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/scheduler/mv/BinlogConsumeStateVO.java 0 1 00.00% [54]
🔵 com/starrocks/task/TabletMetadataUpdateAgentTaskFactory.java 0 1 00.00% [141]
🔵 com/starrocks/qe/ShowExecutor.java 2 3 66.67% [1608]
🔵 com/starrocks/clone/TabletScheduler.java 16 23 69.57% [416, 720, 721, 727, 728, 2064, 2095]
🔵 com/starrocks/clone/TabletChecker.java 15 20 75.00% [364, 366, 638, 645, 646]
🔵 com/starrocks/leader/ReportHandler.java 10 13 76.92% [670, 2067, 2073]
🔵 com/starrocks/clone/TabletSchedCtx.java 5 6 83.33% [928]
🔵 com/starrocks/consistency/CheckConsistencyJob.java 13 15 86.67% [160, 278]
🔵 com/starrocks/server/LocalMetastore.java 10 11 90.91% [1611]
🔵 com/starrocks/clone/DiskAndTabletLoadReBalancer.java 12 13 92.31% [553]
🔵 com/starrocks/lake/Utils.java 2 2 100.00% []
🔵 com/starrocks/transaction/OlapTableTxnStateListener.java 1 1 100.00% []
🔵 com/starrocks/catalog/Partition.java 1 1 100.00% []
🔵 com/starrocks/catalog/CatalogRecycleBin.java 5 5 100.00% []
🔵 com/starrocks/catalog/TabletMeta.java 1 1 100.00% []
🔵 com/starrocks/transaction/LakeTableTxnStateListener.java 2 2 100.00% []
🔵 com/starrocks/clone/ColocateTableBalancer.java 1 1 100.00% []
🔵 com/starrocks/common/proc/StatisticProcDir.java 3 3 100.00% []
🔵 com/starrocks/persist/ConsistencyCheckInfo.java 4 4 100.00% []
🔵 com/starrocks/leader/LeaderImpl.java 1 1 100.00% []
🔵 com/starrocks/consistency/ConsistencyChecker.java 25 25 100.00% []
🔵 com/starrocks/alter/SchemaChangeJobV2.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@meegoo meegoo enabled auto-merge (squash) October 24, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants