Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] only call getAliveComputeNodes once per OlapScanNode (backport #52168) #52268

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 24, 2024

Why I'm doing:

I found some queries which were slow (order of 3-5 seconds) which were bottlenecked in the frontend. Their query profiles indicated that much of the query execution time was spent planning. I did some jstack profiling of the frontends while sending this type of query, see jstack_example9.txt for an example of the profile. The takeaway is that the large majority of threads were busy doing WarehouseManager.getAliveComputeNodes from OlapScanNode.addScanRangeLocations, just to check if there are any living compute nodes. This is done once per PhysicalPartition, even though the check for living CN is not parameterized by anything other than warehouse id. This is wasteful and seriously slow when there are large partition/tablet counts. We can eliminate this bottleneck.

What I'm doing:

Ensuring that getAliveComputeNodes is called once per instance of OlapScanNode (once per query).

This can be seen as a follow up to #46913

Fixes #issue

What type of PR is this:

This is a fix for a performance issue, which I'll call an enhancement.

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #52168 done by [Mergify](https://mergify.com). ## Why I'm doing:

I found some queries which were slow (order of 3-5 seconds) which were bottlenecked in the frontend. Their query profiles indicated that much of the query execution time was spent planning. I did some jstack profiling of the frontends while sending this type of query, see jstack_example9.txt for an example of the profile. The takeaway is that the large majority of threads were busy doing WarehouseManager.getAliveComputeNodes from OlapScanNode.addScanRangeLocations, just to check if there are any living compute nodes. This is done once per PhysicalPartition, even though the check for living CN is not parameterized by anything other than warehouse id. This is wasteful and seriously slow when there are large partition/tablet counts. We can eliminate this bottleneck.

What I'm doing:

Ensuring that getAliveComputeNodes is called once per instance of OlapScanNode (once per query).

This can be seen as a follow up to #46913

Fixes #issue

What type of PR is this:

This is a fix for a performance issue, which I'll call an enhancement.

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…52168)

Signed-off-by: Connor Brennan <cbrennan@pinterest.com>
(cherry picked from commit f581449)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/planner/OlapScanNode.java
#	fe/fe-core/src/test/java/com/starrocks/server/WarehouseManagerTest.java
@mergify mergify bot added the conflicts label Oct 24, 2024
Copy link
Contributor Author

mergify bot commented Oct 24, 2024

Cherry-pick of f581449 has failed:

On branch mergify/bp/branch-3.2/pr-52168
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit f581449f14.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/planner/OlapScanNode.java
	deleted by us:   fe/fe-core/src/test/java/com/starrocks/server/WarehouseManagerTest.java

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) October 24, 2024 04:36
@mergify mergify bot closed this Oct 24, 2024
auto-merge was automatically disabled October 24, 2024 04:36

Pull request was closed

Copy link
Contributor Author

mergify bot commented Oct 24, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant