Create LAMP CSAR #211
Merged
Create LAMP CSAR #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
============================================
- Coverage 63.14% 55.46% -7.69%
- Complexity 616 618 +2
============================================
Files 192 200 +8
Lines 3077 3514 +437
Branches 231 256 +25
============================================
+ Hits 1943 1949 +6
- Misses 1032 1463 +431
Partials 102 102
|
nfode
requested changes
Nov 15, 2017
| @@ -0,0 +1,82 @@ | |||
| <?php | |||
There was a problem hiding this comment.
A php app is no script. I would rename it to myphpapp.php. And move it to another folder.
| // include the credentials to connect to the db | ||
| //include_once "mysql-credentials.php"; | ||
|
|
||
| $db_host = "127.0.0.1"; |
There was a problem hiding this comment.
Why did you put everything into one file? Two files were better?
How do you plan to integrate the inputs? Sorry if it still work in progress.
nfode
requested changes
Nov 15, 2017
| @@ -0,0 +1,4 @@ | |||
| #!/bin/bash | |||
| # install php on a linux machine with php-mysql | |||
| sudo apt-get install php -Y | |||
There was a problem hiding this comment.
The -Y has to be lowercase else it does not work.
|
Edit: Solved. It was a missing apache-php package. I tested the scripts on an EC2 Machine. For this I put a password in the scripts for the mysql-database.
|
nfode
requested changes
Nov 16, 2017
| @@ -0,0 +1,82 @@ | |||
| <?php | |||
There was a problem hiding this comment.
I would move the file out of the scripts folder.
| @@ -0,0 +1,2 @@ | |||
| #!/bin/bash | |||
| sudo mv myphpapp.php /var/www/html/ | |||
There was a problem hiding this comment.
This is more a create_myphpapp.sh script.
There was a problem hiding this comment.
but with this action you start the php application. However i think in the test-csar it doesnt matter
There was a problem hiding this comment.
you don't start it with moving it but nvm
nfode
reviewed
Nov 16, 2017
| db_port: { get_property: [ SELF, database_endpoint, port ] } | ||
|
|
||
| apache_web_server: | ||
| type: tosca.nodes.WebServer |
There was a problem hiding this comment.
Why do you not use the WebServer.Apache type?
There was a problem hiding this comment.
The CSAR uses the WebServer.Apache type now.
|
One ADR collecting the unsupported features? And the supported ones? Maybe
the ADR can be a link to the doc...
Link from Code to ADR to doc: https://adr.github.io/e-adr/ (yeah, currently
Java only... But one could think of a yaml comment format?)
Am 24.11.2017 17:42 schrieb "Heiko Nickerl" <notifications@github.com>:
… ***@***.**** commented on this pull request.
------------------------------
In server/src/test/resources/csars/yaml/valid/lamp-csar_
noinput/template.yaml
<#211 (comment)>
:
> + capabilities:
+ host:
+ properties:
+ num_cpus: 1
+ disk_size: 25 GB
+ mem_size: 2048 MB
+ os:
+ properties:
+ type: linux
+ distribution: ubuntu
+ version: 16.04
+
+ outputs:
+ server_url:
+ description: Concatenated URL with public server address and port
+ value: { concat: [ 'http://', get_attribute: [ server, public_address ], ':', get_attribute: [ server, port ]] }
I simply meant that the concat function is one of these 'nice-to-have'
things of the tosca spec. This template however is supposed to not include
rather fancy aspects of the specification. This shall enable us to use the
template in demo's as soon as possible.
Not sure if we should add an ADR for every feature of the spec that we
don't aim to support right now.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#211 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABTafh03GdjP-C7Nfyj6ssccPZkoIABLks5s5vHqgaJpZM4QfhX5>
.
|
|
For sure we will add this document, don't worry. But to be honest it makes no sense to create one right now. Current state is that we don't support anything 'cause nothing is working yet. If you want I can spend my time writing docs tough. But I'd prefer writing some code to get things going. |
|
Someone else plz. In case someone has capacity remaining though...
Am 24.11.2017 17:50 schrieb "Heiko Nickerl" <notifications@github.com>:
… For sure we will add this document, don't worry. But to be honest it makes
no sense to create one right now. Current state is that we don't support
anything 'cause nothing is working yet. If you want I can spend my time
writing docs tough.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#211 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABTafoxr7_cMzbc1ObXuhxp5f0AxD3rEks5s5vPpgaJpZM4QfhX5>
.
|
|
Added issue #253 |
Just ignore them. Fixing them would be good idea if the application would be a "production" type application. This is just a demo to show that the SQL Connection has been established. Putting more time into that is just completely wasted. |
|
The transformer is rejecting your CSAR (no input) with the following Stack trace |
…to normative Types
|
I don't believe that the parser has issues with non-normative types. It might be that some additional files cannot be found. Can you please provide a minimal example and create an issue at https://github.com/opentosca/winery/issues? Then, @kleinech or @TStadelmaier can have a look. |
|
Non-normative types werden im Gegensatz zu normative types nicht automatisch unterstützt! Lösung: Non-normative types (selbst) definieren und wenn benötigt ins YAML file importieren. |
|
Okay thanks for the info. We assumed the ones specified in Chapter 9 were also supported by the winery. |
|
See issue #260 |
hnicke
approved these changes
Nov 27, 2017
|
I've provided a central zip script (csar-make) which updates all test csars. |
nfode
approved these changes
Nov 28, 2017
c-mueller
added a commit
that referenced
this pull request
Nov 28, 2017
This reverts commit d1e47d4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #208