-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implement
lint
and return LintError
directly
Instead of creating and then parsing a string with a regular expression, we can instead build and return a list of `LintError`s (a typed dict) directly and skip some indirection. I am not sure if `lint` is *supposed* to be overridden like this, but I do remember advocating for it a couple years ago when the change for a proper data structure for lint results was discussed. It just now occ In this particular instance, it allows us to specify a full region for marking the error, where we now specify the entire match including the remainder of the comment instead of just the trigger word. This can be changed, of course, but I figured it wouldn't be a bad idea initially.
- Loading branch information
1 parent
3ed8124
commit 19f7b2e
Showing
1 changed file
with
28 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters