-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement find_errors
and return LintMatch
es directly
#35
Merged
Commits on Jan 29, 2022
-
Implement
lint
and returnLintError
directlyInstead of creating and then parsing a string with a regular expression, we can instead build and return a list of `LintError`s (a typed dict) directly and skip some indirection. I am not sure if `lint` is *supposed* to be overridden like this, but I do remember advocating for it a couple years ago when the change for a proper data structure for lint results was discussed. It just now happened to be a convenient way to implement end markers for the highlighted region. In this particular instance, it allows us to specify a full region for marking the error, where we now specify the entire match including the remainder of the comment instead of just the trigger word. This can be changed, of course, but I figured it wouldn't be a bad idea initially.
Configuration menu - View commit details
-
Copy full SHA for 4e54272 - Browse repository at this point
Copy the full SHA 4e54272View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0754a0 - Browse repository at this point
Copy the full SHA e0754a0View commit details -
Determine row and col from match_region
Since we need to track the region anyway, we might as well extract row and col from it.
Configuration menu - View commit details
-
Copy full SHA for cfb1cf4 - Browse repository at this point
Copy the full SHA cfb1cf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9c31d7 - Browse repository at this point
Copy the full SHA a9c31d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c83427e - Browse repository at this point
Copy the full SHA c83427eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1575f09 - Browse repository at this point
Copy the full SHA 1575f09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ea62b5 - Browse repository at this point
Copy the full SHA 8ea62b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99c0306 - Browse repository at this point
Copy the full SHA 99c0306View commit details -
Configuration menu - View commit details
-
Copy full SHA for f183c1b - Browse repository at this point
Copy the full SHA f183c1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b97421 - Browse repository at this point
Copy the full SHA 8b97421View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26a5ea0 - Browse repository at this point
Copy the full SHA 26a5ea0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad09fec - Browse repository at this point
Copy the full SHA ad09fecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 31ec751 - Browse repository at this point
Copy the full SHA 31ec751View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.