Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a dropdown for wallets and changed UI #7

Closed
wants to merge 5 commits into from
Closed

Added a dropdown for wallets and changed UI #7

wants to merge 5 commits into from

Conversation

muneeb-i-khan
Copy link
Contributor

Note:- Detects and lists all wallets installed but currently connects only to Phantom.

@muneeb-i-khan
Copy link
Contributor Author

PR is made to change the UI as mentioned in the following issue:- #3

@0xPratik
Copy link
Collaborator

Remove the .yarn folder in this PR

@muneeb-i-khan
Copy link
Contributor Author

Done

@0xPratik
Copy link
Collaborator

You have modified the wallet-adapter-ui WalletMultiButton component but a much simpler and easier solution to this would be to implement the UI part of it yourself. I would suggest you check the wallet-adapter-ui react package and see how it's implement

@0xPratik
Copy link
Collaborator

You have modified the wallet-adapter-ui WalletMultiButton component but a much simpler and easier solution to this would be to implement the UI part of it yourself. I would suggest you check the wallet-adapter-ui react package and see how it's implement and then understand the logic of it there and implement it . I wont recommend to add a css module file in this project it's not required and directly interacting with the window object is something i am no sure about all these things logic is already managed by the wallet adapter and the types you have defined are already there in the packages so it's required.

@0xPratik
Copy link
Collaborator

All you need is to focus on the useWallet() hook and the wallets object is going to contain the details

@muneeb-i-khan
Copy link
Contributor Author

Okay I will work on this and get back to you as soon as I am done.

@muneeb-i-khan
Copy link
Contributor Author

Like you said I removed the WalletMultiButton and removed styling from css module file. Please tell me if there are anymore changes that need to be done.

@muneeb-i-khan
Copy link
Contributor Author

@0xPratik I added support for all wallets, updated the UI as you said, added a dropdown menu and removed the WalletMultiButton. Everything looks fine on my end. Please check if everything is okay and let me know if I need to fix anything.

@0xPratik
Copy link
Collaborator

0xPratik commented Feb 8, 2023

Hey I checked out your PR locally and it's quite different than how i intended it to be.
If you have checked the figma file which i added in the issue you might have noticed when the wallet is connected there is logo and wallet address and not a keyword called connected
Screenshot 2023-02-08 at 10 22 30 AM

In this image all the item's are not aligned properly and there is uneven padding/margin which should not be there check the network button for how it should be

Screenshot 2023-02-08 at 10 24 17 AM

When i connect the wallet i get something like this which looks very bad and there should be only disconnect button there and should have similar styles as the network items

Screenshot 2023-02-08 at 10 26 39 AM

In short there are alot of issues in the PR i would suggest to start again in a clean PR

@muneeb-i-khan
Copy link
Contributor Author

Fine. I will open a new PR and try to fix all these issues.

@muneeb-i-khan muneeb-i-khan closed this by deleting the head repository Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants