Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixed: Updated light/dark theme toggle functionality for Sign In/… #1195

Merged

Conversation

rajgharat07
Copy link

…Sign Up pages

Description

Implemented a bug fix that updates the light/dark theme toggle functionality on the Sign In/Sign Up pages :

  • This pull request addresses the issue where the light/dark theme toggle was not functioning correctly on the Sign In and Sign Up pages.
  • The theme would either not persist after navigating between pages or would not update properly when interacting with the toggle button.
  • The changes ensure the theme switches seamlessly between light and dark modes across both pages and retains the selected theme even after page reloads or navigation.
  • Additional improvements have been made to maintain consistency across all form elements and buttons, making the UI visually coherent in both modes.
  • Additionally, the icon was not updating as expected when toggling the theme, so I made necessary adjustments to ensure the icon changes correctly across all relevant components.

Fixes #1193

Screenshots

BEFORE AFTER
I’ve been experiencing issues with adding images for the past 3-4 days. Image

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

Copy link

vercel bot commented Oct 10, 2024

Someone is attempting to deploy a commit to the Suraj Pratap's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
imagine-ai-suraj-pratap10 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 2:30pm

Copy link
Owner

@SurajPratap10 SurajPratap10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SurajPratap10 SurajPratap10 merged commit a72720e into SurajPratap10:main Oct 10, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Light/Dark Mode Toggle Fails When Clicking the Login Button.
2 participants