Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Responsiveness Issues and Overlap of Hamburger Menu and Dark Mode Toggle #1246

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

rajveeerr
Copy link
Collaborator

This pull request addresses the issue where the Hamburger Menu and Dark Mode Toggle were overlapping at certain screen sizes, causing usability issues. The fix sets a breakpoint at 1180px to prevent these elements from overlapping and ensures the UI remains smooth and consistent across all screen sizes.

Changes Made:

  • Updated the CSS to set a breakpoint at 1180px for the navbar.
  • Adjusted the positioning and margins of the Hamburger Menu and Dark Mode Toggle to prevent overlap.
  • Tested on different screen sizes to ensure the UI remains responsive and elements are properly spaced.

Fixes: #1150

Screenshots:

BEFORE AFTER
Screenshot 2024-10-15 at 11 09 07 AM Screenshot 2024-10-15 at 11 22 32 AM

Checklist:

  • Set a breakpoint at 1180px for navbar to avoid overlapping.
  • Adjusted margins and spacing for the Dark Mode Toggle and Hamburger Menu.
  • Tested responsiveness across different devices and screen sizes.

Impact:

This fix improves the user experience by ensuring the UI remains consistent, and all interactive elements are accessible across different screen sizes.

Copy link

vercel bot commented Oct 15, 2024

@rajveeerr is attempting to deploy a commit to the Suraj Pratap's projects Team on Vercel.

A member of the Team first needs to authorize it.

@rajveeerr
Copy link
Collaborator Author

@SurajPratap10 lgtm

Copy link
Owner

@SurajPratap10 SurajPratap10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SurajPratap10 SurajPratap10 merged commit 5df0e86 into SurajPratap10:main Oct 17, 2024
2 of 5 checks passed
@rajveeerr rajveeerr added level2 and removed level1 labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[style]: Improve Breakpoints and Fix UI Overlap of Hamburger Menu and Dark Mode Toggle
2 participants