Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lmrecontest2 #1240

Closed
wants to merge 50 commits into from
Closed

Lmrecontest2 #1240

wants to merge 50 commits into from

Conversation

KrisThielemans
Copy link
Member

Ignore. Testing only

Changes in this pull request

Testing performed

Related issues

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • The code builds and runs on my machine
  • CHANGES.md has been updated with any functionality change

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in SIRF (the Work) under the terms and conditions of the Apache-2.0 License.

evgueni-ovtchinnikov and others added 30 commits May 10, 2022 17:29
@evgueni-ovtchinnikov
implemented basic-functionality listmode data class in C++ and Python
51fed6c
@evgueni-ovtchinnikov
added objective function type for lismode reconstruction
c4be9dd
@evgueni-ovtchinnikov
introduced abstract base class PETScanData for all raw data objects
0063f78
@evgueni-ovtchinnikov
[ci skip] interfaced PETScanData into Python
b143cfc
@NikEfth
Minimal backbone for LM recons
b209f33
@NikEfth
New test for LM data (test6)
31ef16c
@NikEfth
fix
b38b35b
@NikEfth
Merge branch 'HEAD' into lm-recon
036c7c2
@NikEfth
Working test6
65f9fe0
@NikEfth
Generalize the paths in test6
97f76cd
@NikEfth
Minor renaming
26d36fc
@paskino
simplify link library to Boost
db4479d 
closes #1037
@paskino
Merge branch 'master' into HEAD
debcd5b
@paskino
remove dangling endif
b59524c
@NikEfth
Merge pull request #1 from paskino/edo_lm-recon
f65e1de 
Edo lm recon
@evgueni-ovtchinnikov
[ci skip] moved data folder TBPET out of SIRF repo
e4632db
@evgueni-ovtchinnikov
removed unused stuff from cstir_test6.cpp
ea18b8d
@evgueni-ovtchinnikov
restored backward compatibility of run_test6.cpp
7a33289
@evgueni-ovtchinnikov
implemented C interface for list mode reconstruction objective function
7e0e299
@evgueni-ovtchinnikov
started interfacing reconstruction from listmode into Python
47eb909
@evgueni-ovtchinnikov
implemented minimal Python interface for reconstruction from listmode…
08f0425 
… data
@evgueni-ovtchinnikov
resolved some issues raised by Kris
4dd2de7
@evgueni-ovtchinnikov
small amendments in STIR.py
50ef6d4
@evgueni-ovtchinnikov
removed cstir_test6 from ctest tests
eb2ae63
@KrisThielemans
minor fixes to listmode classes
27e5d15
@evgueni-ovtchinnikov
removed some unneeded data_sptr() methods
ef4c9eb
@evgueni-ovtchinnikov
replaced cache_path quick fix with a more proper handling
608f39a
@KrisThielemans
Merge remote-tracking branch 'origin/master' into lm-recon
8b96919
@evgueni-ovtchinnikov
[ci skip] corrected copyrights in cSTIR/tests/test6.cpp
05083e8
@KrisThielemans
make listmode recon compatible with STIR 5.1.0
ed30e6b
KrisThielemans and others added 20 commits March 2, 2023 16:52
@KrisThielemans
Merge branch 'master' into lm-recon
4fa6220
@KrisThielemans
rename PETScanData to ScanData(Python) or STIRScanData (C++)
cd0c423 
This is consistent with our renaming of AcquisitionData
@KrisThielemans
Merge remote-tracking branch 'origin/master' into lm-recon
ab26634
@KrisThielemans
No longer derive ListmodeData from DataContainer
dd4e33e
@KrisThielemans
update listmode test (WIP)
a66667b 
- update to recent SIRF
- use sample data in STIR
- still quite slow as it's precomputing the sensitivity
@KrisThielemans
Derive DataContainer from ContainerBase
5698103 
This allows us to check the type of a container using standard C++ RTTI.
@KrisThielemans
speed-up listmode recon test and use SIRF example data
61e692d 
we had some listmode example data in SIRFdata already, so use that.

reduce segment etc such that the test doesn't take too long
@evgueni-ovtchinnikov
attended to Codacy issues
27eec3d
@evgueni-ovtchinnikov
attended to further Codacy issues
81f1389
@KrisThielemans
fix ListmodeData hierarchy and add get_info to STIR containers
6ed55d8 
- derive ListmodeData from ContainerBase
- add ListmodeData to C wrappers
- add get_info() to STIRImageData and ListmodeData
- expand STIRAcquisitionData::get_info() to add exam-info string
- minimal documentation

This now works fine through Python, but demos still need work.
@KrisThielemans
renamed ListmodeData to STIRListmodeData for consistency
b98c6d0
@KrisThielemans
add set_acquisition_model to listmode obj-fun
713ad10
@KrisThielemans
minor doc corrections
835b499
@KrisThielemans
listmode recon improvements
9ce3b51 
- add ListmodeData::acquisition_data_template()
- let ListmodeToSinograms::set_input() cope with either filename or ListmodeData object
@KrisThielemans
Merge remote-tracking branch 'origin/master' into lm-recon
f009fbf
@KrisThielemans
minor fix in demo
bb42564
@KrisThielemans
fix storing filename of listmode file
56fbace
@KrisThielemans
debug output
464c42c
@evgueni-ovtchinnikov
fixed few small bugs
577d502
@evgueni-ovtchinnikov
attended to Codacy issues
464015b
@KrisThielemans
Copy link
Member Author

closing as this was a test PR. Actual functionality is in #1103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KrisThielemans @evgueni-ovtchinnikov @NikEfth @paskino