Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sapyb to return even if out is not None #1254

Merged
merged 2 commits into from
May 14, 2024
Merged

sapyb to return even if out is not None #1254

merged 2 commits into from
May 14, 2024

Conversation

paskino
Copy link
Contributor

@paskino paskino commented May 13, 2024

Changes in this pull request

With CIL TomographicImaging/CIL#1742 sapyb needs to return even if the output is pre-allocated

Testing performed

Reintroduced test_SIRF.py from CIL.
SyneRBI/SIRF-SuperBuild#897

Related issues

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • The code builds and runs on my machine
  • CHANGES.md has been updated with any functionality change

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in SIRF (the Work) under the terms and conditions of the Apache-2.0 License.

With CIL TomographicImaging/CIL#1742 `sapyb` returns even if the output is pre-allocated
@paskino paskino merged commit d54c455 into master May 14, 2024
1 check passed
@paskino paskino deleted the fix_sapyb_for_cil branch May 14, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants