Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STIR min/max-scale-factor in ScatterEstimation exposed. #1271

Merged
merged 5 commits into from
Jun 25, 2024
Merged

STIR min/max-scale-factor in ScatterEstimation exposed. #1271

merged 5 commits into from
Jun 25, 2024

Conversation

evgueni-ovtchinnikov
Copy link
Contributor

@evgueni-ovtchinnikov evgueni-ovtchinnikov commented Jun 24, 2024 •
edited
Loading

Changes in this pull request

Added min/max_scale_factor methods to scatter estimation classes (C++ and Python).

Testing performed

Related issues

Fixes #1270.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • The code builds and runs on my machine
  • CHANGES.md has been updated with any functionality change

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in SIRF (the Work) under the terms and conditions of the Apache-2.0 License.

@evgueni-ovtchinnikov evgueni-ovtchinnikov added the request Feature request label Jun 24, 2024
@evgueni-ovtchinnikov evgueni-ovtchinnikov self-assigned this Jun 24, 2024
KrisThielemans
KrisThielemans requested changes Jun 25, 2024
View reviewed changes
Copy link
Member

@KrisThielemans KrisThielemans left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent.

src/xSTIR/cSTIR/include/sirf/STIR/stir_x.h Show resolved Hide resolved
src/xSTIR/cSTIR/include/sirf/STIR/stir_x.h Show resolved Hide resolved
@KrisThielemans KrisThielemans added this to the v3.8 milestone Jun 25, 2024
KrisThielemans
KrisThielemans reviewed Jun 25, 2024
View reviewed changes
Copy link
Member

@KrisThielemans KrisThielemans left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a line to CHANGES.md and merge (pull first)

@evgueni-ovtchinnikov evgueni-ovtchinnikov merged commit 947bfef into master Jun 25, 2024
2 of 3 checks passed
@evgueni-ovtchinnikov evgueni-ovtchinnikov deleted the scale-factor branch June 25, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisThielemans KrisThielemans KrisThielemans approved these changes

Assignees

@evgueni-ovtchinnikov evgueni-ovtchinnikov

Labels
enhancement request Feature request
Projects
None yet
Milestone
v3.8
Development

Successfully merging this pull request may close these issues.

Expose the STIR min/max-scale-factor in ScatterEstimation.
2 participants
@evgueni-ovtchinnikov @KrisThielemans