Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility with RAVEN 2.10.0 #391

Merged
merged 2 commits into from
Sep 22, 2024
Merged

fix: compatibility with RAVEN 2.10.0 #391

merged 2 commits into from
Sep 22, 2024

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Sep 22, 2024

Main improvements in this PR:

  • Fixes:
    • Minor fixes to ensure compatibility with RAVEN 2.10.0 (to be released), that has some changes in its importModel and exportModel functions.
    • Rename anaerobicModel to anaerobicModel_GECKO to avoid conflict with yeast-GEM repository.

Instructions on merging this PR:

  • This PR has develop as target branch, and will be resolved with a squash-merge.
  • This PR has main as target branch, and will be resolved with a merge commit.

A yeast-GEM-specific script that ideally should be refactored. For now, just rename to avoid conflict with the function in yeast-GEM repository
Copy link

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 
GECKO installed, unknown version (cannot find version.txt).
Running geckoCoreFunctionTests
Done geckoCoreFunctionTests
__________

Note: In the case of multiple test runs, this post will be edited.

@edkerk edkerk merged commit d461d3a into develop Sep 22, 2024
1 check passed
@edkerk edkerk deleted the fix/newRAVEN branch September 22, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant