Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAVEN 2.9.1 #543

Merged
merged 5 commits into from
May 27, 2024
Merged

RAVEN 2.9.1 #543

merged 5 commits into from
May 27, 2024

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented May 26, 2024

Main improvements in this PR:

  • refactor:
    • when running a unit test and a solver is not installed, report the absence of the solver, not the general failing of the test
  • fix:
    • prevent glpk timeout when running selected large FBA calculations
    • avoid an error when running solveLP in parallel and COBRA toolbox is not installed
    • getAllowedBounds returned inconsistent results when running parallelization
    • various changes in relation to solveLP swapping the sign of reported objective function (sol.f), as already announced with RAVEN release 2.7.12
    • ensure that RAVEN provided libSBML binaries are used, by using unique filenames
    • removeMets also considers metNotes field if available
    • setParam error message if incorrect paramType is specified
  • feat:
    • checkInstallation reports how RAVEN was installed, as described in the Wiki
  • doc:
    • minor changes in formatting of function documentation

Instructions on merging this PR:

  • This PR has develop as target branch, and will be resolved with a squash-merge.
  • This PR has main as target branch, and will be resolved with a merge commit.

* refactor: skip tests if solver is absent

* chore: update github workflow actions/checkout

* fix: close parallel pool if not desired

* fix: extractMiriam bug with multiple miriams

* refactor: tinitTests correct indentation

* fix: tests check for gurobi license

* chore: updateDocumentation

* fix: check gurobi license

* fix: prevent glpk timeout
* fix: code tweaks to allow for parallelization

* fix: exportModel valid libSBML output

* revert: haveFlux faster if not parallelized

* fix: solverTests

* fix: tinitTests check if gurobi is functional

* fix: fillGaps tests check if Gurobi is functional

* fix: rename SBML binaries to ensure being used

* fix: checkInstallation new libSBML filenames

* fix: exportForGit SBML binaries filenames
* fix: correct interpretation sol.f field

* feat: checkInstallation reports installation type
Copy link

github-actions bot commented May 26, 2024

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 > Installation type                    Advanced (via git)
> Installing from location /home/m/actions-runner/_work/RAVEN/RAVEN
> Checking RAVEN release 2.9.0
> You are running the latest RAVEN release
> Checking MATLAB release 2020b
> Checking system architecture glnxa64
> Set RAVEN in MATLAB path Pass
> Save MATLAB path Pass
> Make binaries executable Pass

> Add Java paths for Excel format Pass
> Checking libSBML version 5.20.2
> Checking model import and export
> Import Excel format Pass
> Export Excel format Pass
> Import SBML format Pass
> Export SBML format Pass

> Checking for LP solvers
> glpk Pass
> gurobi Pass
> scip Fail
> cobra Pass
> Set RAVEN solver glpk

> Checking BLAST+ Pass
> Checking DIAMOND Pass
> Checking HMMER Pass

> Checking function uniqueness Pass

*** checkInstallation complete ***

SCIP MEX binary not installed or not functional, some fillGapsLargeTests skipped.
SCIP MEX binary not installed or not functional, some fillGapsSmallTests skipped.
Running blastPlusTests
.
Done blastPlusTests

Running cdhitTests
.
Done cdhitTests

Running checkTasksTests
.
Done checkTasksTests

Running diamondTests
.
Done diamondTests

Running fillGapsLargeTests
.
Done fillGapsLargeTests

Running fillGapsSmallTests
.
Done fillGapsSmallTests

Running hmmerTests
.
Done hmmerTests

Running importExportTests
....
Done importExportTests

Running mafftTests
.
Done mafftTests

Running miriamTests
.
Done miriamTests

Running modelAbilitiesTests
........
Done modelAbilitiesTests

Running modelConversionTests
.
Done modelConversionTests

Running modelCurationTests
.......... ........
Done modelCurationTests

Running modelSortingTests
..
Done modelSortingTests

Running solverTests
..
Error occurred in solverTests/testSCIP and it did not run to completion.
---------
Error ID:
---------
''
--------------
Error Details:
--------------
Error using solverTests>testSCIP (line 77)
SCIP MEX binary not installed or not functional.
..
Done solverTests

Running tinitTests
..........
Done tinitTests

Failure Summary:

Name Failed Incomplete Reason(s)
=====================================================
solverTests/testSCIP X X Errored.

Note: In the case of multiple test runs, this post will be edited.

* fix: setParam correct error message

* fix: removeMets metNotes field

* doc: updateDocumentation
@edkerk edkerk merged commit a1ba114 into main May 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant