-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAVEN 2.10.0 #567
Merged
RAVEN 2.10.0 #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: importModel allows empty params * fix: constructS correct error message missing mets * fix: importExcelModel if faulty MIRIAM are defined * fix: checkModelStruct check reaction reversibility To determine if reaction is reversible, consider all combinations of LB and UB, not just whether LB < 0 or not * doc: getKEGGModelForOrganism dataDir example * chore: updateDocumentation * fix: getExchangeRxns reactionType options * feat: checkModelStruct grRules and genes match
…360) * fix: remove prefix 'M_' and 'R_' in exprotModel function (cherry picked from commit 202087d) * fix: remove prefix `c_` and remaining `R_` * feat: add id format check to function `checkModelStruct` As discussed in #353, this commit introduce regular expressions for checking whether the IDs are in compliance with libSBML specification. * refactor: fully runs `checkModelStruct` by default in `exportModel` - Enable throwing errors when running `checkModelStruct` in `exportModel` - Provide informative error message when reporting invalid ids * fix: checkModelStruct more informative warning if identifiers start with number * feat: exportModel COBRAstyle flag, and deprecate exportGeneComplexes flag * fix: exportModel only add G_ if not already there in all genes * feat: dispEM wrap text in command window * fix: importModel has COBRAstyle flag * fix: update tests to match code changes * fix: checkModelStruct rev warning only * doc: exportModel supressWarnings explanation * doc: checkModelStruct warning about met names * fix: exportModel COBRAstyle then checkModelStruct * fix: readYAMLmodel ec.rxnEnzMat empty last row * feat: importModel more detailed SBML error message * fix: checkModelStruct and exportForGit * fix: checkModelStruct metNames check as warning --------- Co-authored-by: Hao Wang <hao.wang@chalmers.se> Co-authored-by: Mihail Anton <mihail.anton@chalmers.se>
* feat: ravenCobraWrapper supports more fields * feat: proteinNames field * chore: updateDocumentation * fix: import/exportModel and fillGaps test * fix: orderRavenFields proteinNames field * fix: importModel with non-ASCII path
* fix: printOrange prevent double output * fix: exportModel pass through supressWarnings flag
* fix: change model field proteinNames to proteins * fix: enforce column form for model.proteins * doc: importModel more informative warning * chore: update documentation --------- Co-authored-by: Eduard Kerkhoven <eduardk@chalmers.se>
* feat: dedicated funcs to add and rem ID prefixes * refactor: add and rem COBRA prefixes
This PR has been automatically tested with GH Actions. Here is the output of the tests: > Installation type Advanced (via git)
|
* refactor: default behaviour add/remove prefixes * fix: filenames * fix: update test result importExport
Minor release 2.9.3 -> 2.10.0, as changes in handling of identifier prefixes by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
importModel
only removes identifier prefixes (likeR_
for reactions) when present in all entries of a certain type; gives a warning that this happened; and has aremovePrefix
flag that can be set tofalse
if desiredexportModel
only adds identifier prefixes (likeR_
for reactions) when one or more entries of a certain type are not compatible with SBML (i.e. do not start with a letter or _); gives a warning that this happened; and has aneverPrefix
flag that can be set totrue
if desired. Previously, prefixes were always addedimportModel
allows for empty parameters when not specifiedconstructS
gives correct error message when a metabolite is missingimportExcelModel
can ignore faulty MIRIAM entries (note: import of Excel models is strongly discouraged!)checkModelStruct
to determine if reaction is reversible, consider all combinations of LB and UB, not just whether LB < 0 or notcheckModelStruct
checks that all genes ingrRules
field are also ingenes
field (solves checkModelStruct should compare .genes and .grRules #556)checkModelStruct
queries if the model has any identifiers that are not SBML compatible (i.e. do not start with a letter or _)removeIdentifierPrefix
function can remove identifier prefixes likeR_
for reactions if desiredaddIdentifierPrefix
function can add identifier prefixes likeR_
for reactions if requiredmodel.proteins
as field, which matchesmodel.genes
and is also supported by SBML and YAMLgetExchangeRxns
has more options to select reactions based on their reaction bounds, whether they represent uptake, excretion etc. (solves getExchangeRxns.m works inconsistently #555)getKEGGModelForOrganism
explicitly refers to the correctdataDir
options (i.e.prok90_kegg105
oreuk90_kegg105
at this time)Instructions on merging this PR:
develop
as target branch, and will be resolved with a squash-merge.main
as target branch, and will be resolved with a merge commit.