Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vis class UPdate #63

Merged
merged 53 commits into from
May 24, 2024
Merged

Vis class UPdate #63

merged 53 commits into from
May 24, 2024

Conversation

DanRyanIrish
Copy link
Contributor

No description provided.

annavolp and others added 30 commits April 29, 2024 18:23
@annavolp
define first draft definition of visibility class API
aed809b
@annavolp
add phase_uncertainty andamplitude_uncertainty to VisibilityABC
fda39cd
@annavolp
update visibilities API
53a5689
@annavolp
update Visibilities class
689674c
@annavolp
Split up visibilitiesABC into VisibilitiesBaseABC and methods
da235bb
@annavolp
implement VisibilitiesBase and Visibilities class
9b0a9f4
@annavolp
implement amplitude, amplitude_uncertainty, phase, phase_uncertainty
2d9428c
@annavolp
implement VisMeta class
d89fd35
@annavolp
fix indentation
342b951
@annavolp
fix the bugs
8b258ff
@annavolp @DanRyanIrish
Update xrayvision/visibility.py
bdbbe70 
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
@annavolp
fix the bugs in VisibilitiesBase class
2b3c9c3
@DanRyanIrish
Add slicing by name to Visibilities class.
a64462f
@DanRyanIrish
Merge branch 'vis_class' of https://github.com/annavolp/xrayvision in…
8e3d444 
…to vis_class
@annavolp
update in Visibilities Classs
84f1a87
@DanRyanIrish
Make underlying Visibilities data structure an xarray.
46e44ad
@DanRyanIrish
Merge branch 'vis_class' of https://github.com/annavolp/xrayvision in…
06eb355 
…to vis_class
@DanRyanIrish
removes defunct getitem from VisibilitiesBase.
ffd087e
@annavolp
Merge pull request TCDSolar#1 from DanRyanIrish/vis_class
2f87e85 
Make underlying data structure for Visibilities class an xarray
@annavolp
Update test_visibility.py
bf5e986
@DanRyanIrish
Add xarray as dependency to package.
2ae7b43
@DanRyanIrish
Fix bug in VisibilitiesBase __init__ and fix codestyle.
f0a8500
@DanRyanIrish
Merge branch 'main' of https://github.com/TCDSolar/xrayvision into vi…
0e8ae99 
…s_class
@annavolp
Merge pull request TCDSolar#2 from DanRyanIrish/vis_class
e607b3c 
Update Vis class PR
@DanRyanIrish
Update VisMeta class so its call signature is a little more like ndcu…
28ff120 
…be.Meta
@DanRyanIrish
Fix codestyle.
c4c5569
@DanRyanIrish
Add changelog.
4264858
@DanRyanIrish
Docstring improvements.
faac140
@annavolp
Merge pull request TCDSolar#3 from DanRyanIrish/vis_class
dd55a38 
Update Vis_class PR (Part 2)
@annavolp @DanRyanIrish
Apply suggestions from code review
757cf38 
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
DanRyanIrish and others added 22 commits May 21, 2024 17:31
@DanRyanIrish
Update Visibilities API, including moving phase center to attribute o…
e30e7b4 
…n to level of class.
@DanRyanIrish
Consolidate new Visibilities API into single ABC and implemented class.
9377362
@DanRyanIrish
Fix codstyle.
ccd7787
@DanRyanIrish
Make meta getter on Visibilities class more flexible.
cb9170d
@DanRyanIrish
Add setter for phase center.w
0c54fd6
@DanRyanIrish
Fix codestyle
3e56e05
@DanRyanIrish
Fix typo.
6dd0212
@DanRyanIrish
Reduce call signature of Visibilities class by relying on meta to inc…
ce4c015 
…lude optional metadata, rather than top level kwargs. Also add instrument attribute to VisMeta.
@DanRyanIrish
Introduce input type checking to VisMeta. Also make unit typing consi…
8237d25 
…stent.
@DanRyanIrish
Fix Visibilities.meta so vis labels output is of correct type.
5d6a64a
@DanRyanIrish
Update changelog 55.
2d4a97a
@DanRyanIrish
Update visibility.__all__
311153e
@DanRyanIrish
Remove VisMeta phase_center setter.
a58700a
@DanRyanIrish
Remove phase_center from VisMeta and store directly on Visibilities c…
6ab3cbb 
…lass.
@DanRyanIrish
Change changleog 55 to changelog 62.
a9c89bf
@DanRyanIrish
Rename changlelog 62 back to 55.
6c1de94
@DanRyanIrish @samaloney
Apply suggestions from code review
7d53d29 
Co-authored-by: Shane Maloney <maloneys@tcd.ie>
@DanRyanIrish
Apply changes from code review.
0a84137
@DanRyanIrish
Fix codestyle.
ed379cc
@DanRyanIrish
Fix meta typing for Visibilities class.
8b1fff7
@DanRyanIrish
Merge branch 'main' of https://github.com/TCDSolar/xrayvision into vi…
bbc5ab6 
…s_class
@DanRyanIrish
Add changelog 63.
4a4fad9
@codecov Codecov
Copy link

codecov bot commented May 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@8580373). Learn more about missing BASE report.

Files Patch % Lines
xrayvision/visibility.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage        ?   89.14%           
=======================================
  Files           ?        7           
  Lines           ?      829           
  Branches        ?        0           
=======================================
  Hits            ?      739           
  Misses          ?       90           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samaloney samaloney merged commit 4f1d619 into TCDSolar:main May 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanRyanIrish @samaloney @annavolp