Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make software compatible with Visibilities class #67

Merged
merged 13 commits into from
Jun 1, 2024

Conversation

paolomassa
Copy link
Contributor

First version of the modifications needed to make the software compatible with the Visibilities class

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@dcd2a3e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
xrayvision/mem.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage        ?   89.43%           
=======================================
  Files           ?        7           
  Lines           ?      890           
  Branches        ?        0           
=======================================
  Hits            ?      796           
  Misses          ?       94           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@samaloney samaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks ok - do the demos make ok images? Also does this version work with the stixpy as in do the images look ok.

xrayvision/imaging.py Show resolved Hide resolved
@samaloney
Copy link
Member

The test fails are from the examples need to update the examples too and make sure the images also look the same before and after.

examples/rhessi.py Outdated Show resolved Hide resolved
xrayvision/mem.py Outdated Show resolved Hide resolved
xrayvision/tests/test_imaging.py Outdated Show resolved Hide resolved
xrayvision/imaging.py Show resolved Hide resolved
paolomassa and others added 2 commits May 31, 2024 21:39
Co-authored-by: Shane Maloney <maloneys@tcd.ie>
Co-authored-by: Shane Maloney <maloneys@tcd.ie>
examples/rhessi.py Outdated Show resolved Hide resolved
Copy link
Member

@samaloney samaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @paolomassa

@samaloney samaloney merged commit d195e70 into TCDSolar:main Jun 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants