Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ design ] 후배 약속 리스트 - 텅 뷰 가운데 정렬 #220

Merged
merged 1 commit into from
Aug 19, 2024
Merged

[ design ] 후배 약속 리스트 - 텅 뷰 가운데 정렬 #220

merged 1 commit into from
Aug 19, 2024

Conversation

se0jinYoon
Copy link
Collaborator

#️⃣ Related Issue

Closes #219

✅ Done Task

  • 후배 약속 리스트 - 텅 뷰 가운데 정렬

☀️ New-insight

  • 추출한 svg가 아이폰 SE에만 맞는 사이즈여서 모든 부분에서 전체 사이즈 차지하도록 변경했습니다 ~

💎 PR Point

  • 너무 간단한 거라 없음
  • 간단한 거라 걍 다 담 ㅋ

📸 Screenshot

2024-08-12.11.29.55.mov

@se0jinYoon se0jinYoon added 💄 Design 스타일 구현 서진 labels Aug 12, 2024
@se0jinYoon se0jinYoon self-assigned this Aug 12, 2024
ijieun
ijieun approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@ijieun ijieun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대체 얼마나 간단한거지? 했는데 정말 간단하네요. 정말 깔끔한 코드입니다. LGTM

j-nary
j-nary approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@j-nary j-nary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드가 복잡해서 코드 해석하는데 좀 오래걸렸네용 LGTM 💓

@se0jinYoon se0jinYoon merged commit efe88be into develop Aug 19, 2024
1 check passed
@se0jinYoon se0jinYoon deleted the design/#219/seniorHomeEmptyCenter branch August 19, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-nary j-nary j-nary approved these changes

@ijieun ijieun ijieun approved these changes

Assignees

@se0jinYoon se0jinYoon

Labels
💄 Design 스타일 구현 size/xs 서진
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ design ] 후배 약속리스트 텅 뷰 가운데정렬
3 participants
@se0jinYoon @j-nary @ijieun