-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Refactor ] JuniorPromiseRequest 라우팅 분리 #221
Merged
Merged
Changes from 21 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
511f901
refactor: juniorPromiseRequest 파일 이동
ijieun 89b7e92
refactor: 라우터 분리, 페이지 이동 방식 변경
ijieun 25e8f0b
fix: react-router-dom의 import문 합치기
ijieun 198d605
refactor: state를 사용하지 않고 navigate 이동하도록 코드리뷰 반영
ijieun fc0f7f4
refactor: state없이 구조분해할당으로 받아오도록 코드리뷰 반영
ijieun e619cd1
fix: header < 클릭시 이전 페이지 이동
ijieun 4cd44d2
chore: 컴포넌트 제거
ijieun 6c83100
design: 약속 신청 모달 가운데로 정렬
ijieun b99474d
fix: 이미 있는 약속을 신청할 시에 alert알림
ijieun 90020eb
fix: 변수, 속성 이름 축약
ijieun d7bd928
refactor: 약속신청 버튼 인라인 조건부 렌더링
ijieun a3e410b
Merge branch 'develop' into refactor/#218/separateRoute
ijieun 6854730
refactor: isAllSelected 상태 함수 제거
ijieun 96d4527
Merge branch 'refactor/#218/separateRoute' of https://github.com/TEAM…
featuring-sophia 65a9cb8
refactor: isAllSelected 상태 함수 제거
ijieun cd556c4
Merge branch 'refactor/#218/separateRoute' of https://github.com/TEAM…
ijieun 940f74f
refactor: 에러 핸들링 로직 분리
ijieun d77d769
Merge branch 'refactor/#218/separateRoute' into fix/#222/patchSelfQA
ijieun 8a7345a
Merge pull request #225 from TEAM-SEONYAK/fix/#222/patchSelfQA
ijieun 3e7f505
fix: 변수 맞춤법 수정
ijieun 163adc4
Merge branch 'develop' into refactor/#218/separateRoute
ijieun f07cb14
refactor: 중복 코드 합치기
ijieun d1335ad
refactor: 약속 신청 에러 핸들링 로직 변경
ijieun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 0 additions & 38 deletions
38
src/pages/juniorPromise/components/promiseRequest/CheckModal.tsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
6 changes: 3 additions & 3 deletions
6
...ponents/promiseRequest/ScheduleSelect.tsx → ...miseRequest/components/ScheduleSelect.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...se/components/promiseRequest/TimeList.tsx → ...iorPromiseRequest/components/TimeList.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...mponents/promiseRequest/WorryTextarea.tsx → ...omiseRequest/components/WorryTextarea.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p1) 근데 여기 기존에는 isAllSelected일 경우에만 실행되던 로직인 것 같은데, 해당 조건없이 실행되도록 두어도 괜찮은가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요게 첫번째 화면을 거쳐서 '적용할래요' 버튼을 누르면 그제서야 '약속 신청 post 요청'이 되는 로직입니다!!
원래 중복 검사를 했지만, 어차피 첫번째 화면처럼 모달이 open 되기 위해서는 isAllSelected 검사를 먼저 수행하고, '적용할래요' 버튼을 누르는 시점에서는 이미 검사를 수행한 이후라 불필요한 검사 과정인 것 같아서 뺐습니당!! 기억력 좋타.. 혹시 중복 검사를 하는게 더 낫다고 생각하시나요 ??!
요 화면에서 검사 진행함다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오호 아니요!! 굿입니다~~~ 머지해주세여!!